Repository navigation
feat(properties): dock centre-on-label tools into POSITION section he… - #101
Merged
Merged
Conversation
…ader The three AlignButtons appeared as a free-floating row beneath the X/Y inputs (leaf) or beneath the multi-select hint, with no visual anchor to the position section. Users had to hover to discover what the icon-only buttons did. Dock the toolbar into the POSITION section header via a single PositionSectionHeader component (used by the leaf, group and multi- select branches), following the Figma / Sketch / Affinity convention where align tools sit at the section header. The header label is linked to the AlignButtons group via `useId` + `aria-labelledby`, so screen readers announce a "Position, button group, …" rather than three isolated icon buttons. Restyle the buttons borderless with smaller padding so they read as inline header tools instead of form controls.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the layout and accessibility of the alignment tools in the properties panel. It introduces a new PositionSectionHeader component that groups the section label and the AlignButtons component together, using React's useId to link them with aria-labelledby for better screen reader support. The AlignButtons component has also been updated with borderless styling and a group role. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.