Sunil mohan adapa django 1.9

[tzangms]

No description provided.

[tzangms]

@SunilMohanAdapa @aouaki Is there any change you guys could do code review for me?

[SunilMohanAdapa]

@tzangms I'd be happy to. Will try to do this as soon as find some time (today/tomorrow).

[aouaki]

This should be < (1, 8) since using Context instances has been deprecated as of Django 1.8

[aouaki]

And this has no reason to be anymore

[aouaki]

Reviewed

[JosephKiranBabu]

@tzangms @aouaki Can this be reviewed and merged soon? This is causing bugs in a dependent projects like Plinth. freedombox/Plinth#900 and freedombox/Plinth#894

[tzangms]

Hi All,

Sorry for the late reply, I've did some modify suggested by @aouaki
and released a new version 3.3 on PyPI.

https://pypi.python.org/pypi/django-bootstrap-form/3.3

Please test before put on production, thanks!

[JosephKiranBabu]

@tzangms Thanks for the quick response.

[JoKeyser]

Sorry to poke again, but will the merge also solve https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865938 ? That's the current issue threatening Plinth to be deleted from Debian, I don't have time to look at this right now.

[tzangms]

Hi @JoKeyser

I've take a looks at the detail, but is there any document to follow to solve this problem?

[JoKeyser]

Hi @tzangms , thank you looking into this! And sorry, I also don't know what the best answer is here. Probably @SunilMohanAdapa or @jvalleroy or @petterreinholdtsen know what the best solution is.

In my understanding, the Debian maintainer or another Debian developer(?) would have to finally upload a working (i.e. building-from-source) package to the Debian archive. You (and maybe tomorrow, me) could help by checking whether the problem of bug 865938 would still exist in the current version, now that this PR got merged. Sorry, I just don't have time today.

[tzangms]

Oh, I think I miss read the message in Debian bug report page, obviously there is a test error should be fixed, though the unit test is passed in every test on Travis CI.

[JoKeyser]

I'm sorry, my previous 2 posts were confusing (because I was confused myself).
The Debian issue https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865938 actually links back to PR #86. As the maintainer, @thomasgoirand says there, the patch is currently necessary to build from source, which is a requirement to remain in Debian (along with all depending package in Debian).
The new Django version 1.11.3 makes another, but very similar patch necessary, which I posted to bug 865938 as an attached patch.
So I think the smartest/easiest way forward would be if PR #86 gets merged and even generalized to also get rid of the similar problem with Django 1.11.3.