-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kdl-unofficial-template:0.1.0 #1787
Conversation
checking rn what is going on - was developing this with 0.12 and things worked well |
the error I am seeing is from cetz |
If you are not in a hurry, I would like to wait for a new version of cetz to be released with a fix for that, so that you can publish your package without any warning. If you prefer we can also merge right now, but then it would be nice if you could publish another version to update cetz once possible. |
I've been sitting on this for a few months - so a little bit extra waiting time is no big deal, I've had a look at the CeTZ PR fixing this issue, but I am missing too much context to make a meaningful contribution reviewing that one. |
the issue has been fixed on CeTZ side, but the release of it is in 0.4.0 - which is hopefully happening in the near future. in the mean time could someone check if the package meets the best practises, so I fix stuff while waiting for the 0.4.0 release of CeTZ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font files should not be committed to this repository. You should add instructions in your README or in the template on how to install and use them with Typst instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it allowed to distribute content using this logo?
license = "MIT" | ||
entrypoint = "lib/lib.typ" | ||
description = "An unofficial template for community scenarios for the TTRPG 'KULT: divinity lost'" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As reported by the CI, you should include at least one category for your package.
license = "MIT" | ||
entrypoint = "lib/lib.typ" | ||
description = "An unofficial template for community scenarios for the TTRPG 'KULT: divinity lost'" | ||
category = "book" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Categories should always be a list, even if there is a single one.
category = "book" | |
categories = ["book"] |
d2466b4
to
a44bdc3
Compare
Thank you :) |
I am submitting
an update for a packageThis is a TTRPG scenario template for the horror roleplaying game "KULT: divinity lost" - the scenarios themselves have to be released under the conditions for fan made scenarios.
The package/template gives scaffolding for writing full scenarios in a printer and non-printer friendly version including character sheets, title pages, chapters, i.e. everything I could think of.
I have read and followed the submission guidelines and, in particular, I
selected a name that isn't the most obvious or canonical name for what the package does
added a
typst.toml
file with all required keysadded a
README.md
with documentation for my packagehave chosen a license and added a
LICENSE
file or linked one in myREADME.md
tested my package locally on my system and it worked
exclude
d PDFs or README images, if any, but not the LICENSEensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.
Hey this is my first template/package I've tried to do my best to test it, but I'd appreciate someone else trying as well.
All the best
Martin