Add more stars

[T0mstone]

I'm happy to receive any feedback about the names.

Unicode Weirdness

Four-pointed Stars

There's two black four-pointed stars,

• U+2726 "Black Four Pointed Star"
• U+1F7C6 "Four Pointed Black Star"
  I chose to go with the second one since the first one is from the "Dingbats" block, not from "Geometric Shapes Extended".
  There's also U+2727 "White Four Pointed Star", which I haven't added since it'd be weirdly inconsistent.

Edit: The source (mentioned below) says "2726 ✦ is a cusp", so not having it or 2727 as stars is probably correct.

Five-pointed Stars

I'm assuming the original star is intended to be five-pointed (but idk how much of this is just fonts agreeing with each other rather than Unicode actually saying something about it. Where do you get all that secret Unicode information about how characters are supposed to look?)

In particular, note how there's U+1F7C9 "Light Five Pointed Black Star" and U+1F7CA "Heavy Five Pointed Black Star", but no plain "Five Pointed Black Star".
There's also U+066D "Arabic Five Pointed Star", which I don't know what to do with.

Currently, I've added the former two as star.filled.{light, heavy}.

Edit: I found the official source: https://www.unicode.org/charts/PDF/U1F780.pdf
It says

Constitute a set as follows: 1F7C9, 2605, 1F7CA, and 272F

So attaching them without an extra qualifier is correct.

Eight-pointed Stars

U+1F7D0 is called "Very Heavy Eight Pointed Black Star". What do we call this modifier? I've gone with veryheavy for now, but I don't think this is a good choice.

Variation Selectors

https://www.unicode.org/Public/8.0.0/ucd/StandardizedVariants.html has an entry for U+2734 (star.eight.filled), so it should get a VS15 when #25 is resolved.

My font shows U+1F52F "Six Pointed Star with Middle Dot" in emoji style by default. VS15 does work, but this isn't listed in the above table. Is this a nonstandard variant?
Regardless, it should then also get a VS15.

[T0mstone]

Should I also add the "asterisk" symbols? (e.g. U+1F7AF 🞯 "LIGHT FIVE SPOKED ASTERISK") They're not really "punctuation" like the current sym.ast, but they're not officially "stars"...

[MDLC01]

I left some thoughts in the review comments.

Additionally, maybe U+2726 ✦ should be added as star.cusp, star.filled.cusp, or star.four.filled.cusp.

Moreover, I'm not sure I understand why you said that "attaching them without an extra qualifier is correct" given that the charts mention, as you noted, that five pointed stars constitute a set containing U+1F7C9, U+2605, U+1F7CA, and U+272F.

[MDLC01]

I don't really like .outlined, but I don't have a good alternative either.

[T0mstone]

Moreover, I'm not sure I understand why you said that "attaching them without an extra qualifier is correct" given that the charts mention, as you noted, that five pointed stars constitute a set containing U+1F7C9, U+2605, U+1F7CA, and U+272F.

Note how U+2605 is just star.filled. Another idea would be renaming that to star.five.filled, then the other ones could follow suit. In that case, we could also rename the pentagram to star.five.something, tho I don't really like star.five.stroked since the strokes cross each other rather than being an outline only.

Same with star.six.david; That one is a well-established symbol (i.e. the name already makes it clear), so it might be fine to treat it as the six-pointed equivalent to the pentagram.

[T0mstone]

Additionally, maybe U+2726 ✦ should be added as star.cusp, star.filled.cusp, or star.four.filled.cusp.

In that case we should also add all the other cusps. There are more of them and I was thinking of leaving them for later.

[T0mstone]

There, I've added the .five modifier to all the regular stars (except for .op, which I feel is supposed to be more abstract), since the regular star.filled is (by association) five-pointed, and thus (tho I'm not perfectly sure about this) all its plain derivatives can be assumed to be five-pointed as well.

I then went and made the david star and the pentagram the same modifier, namely .crossing, since the strokes are crossing each other.

[MDLC01]

Forgive me if I'm missing something obvious: I find it very hard to review so many interconnected symbols. Anyway, here are my comments.

• I still don't like the .outlined modifier in star.five.stroked.outlined. Maybe we could use .laced for that? Now that we no longer use this modifier for a different purpose.
• .three variants and .four variants are the only ones for which the bare .filled variant is heavier than the .filled.medium variant.
  • I know you followed Unicode, but I think we should try to be consistent before trying to follow Unicode.
• Maybe U+2726 ✦ BLACK FOUR POINTED STAR could be added (under which name, though?).

[T0mstone]

No worries!

I still don't like the .outlined modifier in star.five.stroked.outlined. Maybe we could use .laced for that? Now that we no longer use this modifier for a different purpose.

I think I said this before, but do you have any evidence that it's actually laced other than just the font happened to design it that way? I'm all for this change if that concern could be dealt with.

.three variants and .four variants are the only ones for which the bare .filled variant is heavier than the .filled.medium variant.
I know you followed Unicode, but I think we should try to be consistent before trying to follow Unicode.

Okay, sure, we already changed the weight names for the eight-pointed ones, so why not these as well.

Maybe U+2726 ✦ BLACK FOUR POINTED STAR could be added

In that case we should also add U+2727 ✧ WHITE FOUR POINTED STAR and U+2BCC ⯌ LIGHT FOUR POINTED BLACK CUSP to U+2BCF ⯏ ROTATED WHITE FOUR POINTED CUSP.

[MDLC01]

I'm realizing this now: maybe this should be .b instead of .inv (as in, pointing to the bottom), and the other .five variants would have an additional .t modifier. I prefer it the way it is now, but I'm so lost with all those stars I figured it may be good to share this idea.

[MDLC01]

r.five.stroked.outlined. Maybe we could use .laced for that? Now that we no longer use this modifier for a different purpose.

I think I said this before, but do you have any evidence that it's actually laced other than just the font happened to design it that way? I'm all for this change if that concern could be dealt with.

I am realizing now how annoying this is: the .crossed.{l,r} variants are laced, and this one is too. With this realization in mind, I now dislike the .l and .r modifiers for star.five.crossing. Maybe we can just remove three variants for now and leave them for later?

Maybe U+2726 ✦ BLACK FOUR POINTED STAR could be added

In that case we should also add U+2727 ✧ WHITE FOUR POINTED STAR and U+2BCC ⯌ LIGHT FOUR POINTED BLACK CUSP to U+2BCF ⯏ ROTATED WHITE FOUR POINTED CUSP.

If you have good name ideas, let's add them. Otherwise, we can keep them for later.