Replace postinstall script with prepare #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not safe to do this. See: https://gist.github.com/djcsdy/3ca078e23fdac4c50e077c84e8284a95 Since we build and publish pinst using npm, not yarn, we can run husky in the prepare step instead of postinstall. Then we don't need to use pinst to publish pinst :-).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not safe to run pinst in the prepack script.
See also #24, #23, #22.
It seems like a bad idea to keep the broken
prepackscript in the source of pinst itself.Since we build and publish pinst using npm, not yarn, we can run husky in the
preparestep instead ofpostinstall. Then we don't need to use pinst to publish pinst :-).