Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mentions of CSDK, replace with general Adobe IO authentication… #1
base: master
Are you sure you want to change the base?
Remove mentions of CSDK, replace with general Adobe IO authentication… #1
Changes from all commits
558f29a
59c6f33
f53c42c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, there's nothing in https://www.adobe.io/authentication.html for web fonts preview API. It uses a completely different auth mechanism. @bramstein or @pzula should confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's correct. It is a separate system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jani9000 I'm not following. Are you saying that this revision is inaccurate? Or can it stand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbrown You should remove the part about adding an authentication component (it's not needed for web fonts preview API):
"Using the API requires authentication via an auth_id and auth_token. To get these, register with us by using the Adobe I/O Console to create an integration. Then add an authentication component and return to the Console to request a Web Font Preview API token (in an integration’s Services tab, you'll find a token generator in the “Configure Typekit Platform” area)."
...should be:
"Using the API requires authentication via an auth_id and auth_token. To get these, register with us by using the Adobe I/O Console to create an integration and to request a Web Font Preview API token (in an integration’s Services tab, you'll find a token generator in the “Configure Typekit Platform” area)."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This auth token" is a little ambiguous. "Sign in with their Adobe ID" should link to the OAuth 2.0 guide:
https://www.adobe.io/authentication/auth-methods.html#!adobeio/adobeio-documentation/master/auth/OAuth2.0Endpoints/web-oauth2.0-guide.md.
Maybe this doc should have an explicit section about the two different auth mechanisms used for web based integrations — one for loading preview fonts using Web Fonts Preview API, and another to call Typekit Platform API endpoints as a logged in user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jani9000 Added the link, good call.
The guide mentions both auth steps in the previous paragraph (line 23):
What if we retitled the heading above that paragraph like this?