Skip to content

Conversation

@xintamosaik
Copy link
Contributor

I might miss something but why is the DryMongoBinaryOption for platform fed with 'version' instead of 'platform'?

Related Issues

Potentially Typesupport issues in IDEs that use LSP

I might miss something but why is the DryMongoBinaryOption for platform fed with 'version' instead of 'platform'?
Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, it does not change the type from string, but you are correct, it should be platform for platform.

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.96%. Comparing base (7d07e96) to head (22a14d3).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   92.06%   91.96%   -0.10%     
==========================================
  Files          15       15              
  Lines        2104     2104              
  Branches      524      534      +10     
==========================================
- Hits         1937     1935       -2     
+ Misses        167      162       -5     
- Partials        0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hasezoey hasezoey merged commit efc8460 into typegoose:master Oct 6, 2025
10 of 11 checks passed
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Oct 7, 2025
@xintamosaik xintamosaik deleted the patch-1 branch October 12, 2025 19:10
@xintamosaik
Copy link
Contributor Author

Thanks from me and my OCD ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Pull Request released | Issue is fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants