Validation of the fields argument to bulk_update
#2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Sep 11, 2025
| return False | ||
|
|
||
| if not field.concrete or field.many_to_many: | ||
| ctx.api.fail(f'bulk_update() can only be used with concrete fields. Got "{field_name}"', ctx.context) |
There was a problem hiding this comment.
Suggested change
| ctx.api.fail(f'bulk_update() can only be used with concrete fields. Got "{field_name}"', ctx.context) | |
| ctx.api.fail(f'"bulk_update()" can only be used with concrete fields. Got "{field_name}"', ctx.context) |
| all_pk_fields.update(parent._meta.pk_fields) | ||
|
|
||
| if field in all_pk_fields: | ||
| ctx.api.fail(f'bulk_update() cannot be used with primary key fields. Got "{field_name}"', ctx.context) |
There was a problem hiding this comment.
Suggested change
| ctx.api.fail(f'bulk_update() cannot be used with primary key fields. Got "{field_name}"', ctx.context) | |
| ctx.api.fail(f'"bulk_update()" cannot be used with primary key fields. Got "{field_name}"', ctx.context) |
| return ctx.default_return_type | ||
|
|
||
| if len(fields_args.items) == 0: | ||
| ctx.api.fail("Field names must be given to bulk_update()", ctx.context) |
There was a problem hiding this comment.
Suggested change
| ctx.api.fail("Field names must be given to bulk_update()", ctx.context) | |
| ctx.api.fail('Field names must be given to "bulk_update()"', ctx.context) |
| def get_fields() -> list[str]: | ||
| return ["title"] | ||
| Article.objects.bulk_update(articles, get_fields()) |
There was a problem hiding this comment.
Please, test at least one error with .abulk_update.
Do we have similar missing tests with other a methods?
| Article.objects.bulk_update(articles, ["published"]) | ||
| # Valid multiple field updates | ||
| Article.objects.bulk_update(articles, ["title", "content"]) |
There was a problem hiding this comment.
Suggested change
| Article.objects.bulk_update(articles, ["title", "content"]) | |
| Article.objects.bulk_update(articles, ("title", "content")) |
just for the variaty.
| isinstance(ctx.type, Instance) | ||
| and (django_model := helpers.get_model_info_from_qs_ctx(ctx, django_context)) is not None | ||
| and len(ctx.args) >= 2 | ||
| and ctx.args[1] |
There was a problem hiding this comment.
Please, don't forget to support TupleExpr and SetExpr here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Mostly mirrors validation logic from
django.db.models.query.QuerySet.bulk_update.Tests are inspired from
django/tests/queries/test_bulk_update.pyI could have called a dummy
bulk_updatewith no objects to reuse django internal logic but it felt brittle with risk of someday actually do database query so I preferred to re-implement the few checks