feat: evm multi chain signer by ljankovic-txfusion · Pull Request #7 · txfusion/hyperlane-monorepo

ljankovic-txfusion · 2024-11-12T15:44:03Z

No description provided.

ltyu

first pass. i like the progress!

ltyu · 2024-11-12T16:29:08Z

typescript/cli/cli.ts

    .command(submitCommand)
    .command(validatorCommand)
    .command(warpCommand)
+    .command(strategyCommand)


can we alphabetize this?

ltyu · 2024-11-12T16:31:36Z

typescript/cli/src/commands/strategy.ts

+      description:
+        'Type of submitter (jsonRpc, impersonatedAccount, gnosisSafe, gnosisSafeTxBuilder)',
+    },
+    safeAddress: {


since it looks like we prompt these based on the type, do we need this?

You are right!

ltyu · 2024-11-12T16:39:34Z

typescript/cli/src/commands/strategy.ts

+      false,
+      'The path to output a Strategy Config JSON or YAML file.',
+    ),
+    type: {


do we need this? users are prompted to select a set, but in this case we also allow users to enter their own type (i believe this will fail for unsupported submitter types)?

i suggest we just stick to 1: prompt users to select

ltyu · 2024-11-12T16:44:39Z

typescript/cli/src/commands/strategy.ts

+  },
+};
+
+function isValidPrivateKey(privateKey: string): boolean {


could be useful in other places. consider moving to utils

ltyu · 2024-11-12T16:47:15Z

typescript/cli/src/commands/strategy.ts

+        );
+        submitter.chain = chain;
+
+        if (type === TxSubmitterType.GNOSIS_TX_BUILDER) {


do we need this? already inside of case TxSubmitterType.GNOSIS_TX_BUILDER

On lines 139 & 140 we handle gnosis safe and tx builder(uses 1.0 as the default version):

case TxSubmitterType.GNOSIS_SAFE: case TxSubmitterType.GNOSIS_TX_BUILDER:

ltyu · 2024-11-12T17:37:45Z

typescript/cli/src/context/context.ts


 import { isSignCommand } from '../commands/signCommands.js';
+import { readDefaultStrategyConfig } from '../config/strategy.js';
+// import { readDefaultStrategyConfig } from '../config/strategy.js';


ltyu · 2024-11-12T17:55:16Z

typescript/cli/src/context/strategies/chain/MultiChainHandler.ts

+        'warp',
+      );
+    } else {
+      console.log(`Using warp route deployment config at ${configPath}`);


can we use the logger here instead?

ltyu · 2024-11-12T17:56:21Z

typescript/cli/src/context/strategies/chain/MultiChainHandler.ts

+    }
+
+    const warpRouteConfig = readYamlOrJson(configPath);
+    assert(


no need to assert because if the file doesn't exists, readYamlOrJson will throw

ltyu · 2024-11-12T17:57:54Z

typescript/cli/src/config/strategy.ts

+  filePath: string,
+): Promise<ChainSubmissionStrategy> {
+  const config = readYamlOrJson(filePath);
+  assert(config, `No default strategy config found at ${filePath}`);


no need to assert, readYamlOrJson will throw

ltyu · 2024-11-12T18:21:22Z

typescript/cli/src/context/strategies/submitter/JsonRpcStrategy.ts

+
+    return (
+      submitter?.privateKey ??
+      (await password({


ljankovic-txfusion · 2024-11-13T09:36:27Z

typescript/cli/src/deploy/warp.ts

  await writeDeploymentArtifacts(warpCoreConfig, context);

-  await completeDeploy(context, 'warp', initialBalances, userAddress, chains);
+  await completeDeploy(context, 'warp', initialBalances, null, chains!);


User address will be determined by the signer associated to one of the chains in the prepareDeploy and completeDeploy functions

ljankovic-txfusion · 2024-11-13T09:37:31Z

typescript/cli/src/send/transfer.ts

-      'Select the destination chain',
-    );
-  }
-


This logic is outsourced to signerMiddleware

ljankovic-txfusion · 2024-11-13T09:39:50Z

typescript/cli/src/send/message.ts

-      'Select the destination chain',
-    );
-  }
-


This logic is outsourced to signerMiddleware -> user is prompted to select origin & destination (if not provided in CLI) before reaching sendTestMessage function call

… file

…ntext multiprovider

…Module

…to feat/key-command

…ter props

…ne-xyz#5468) ### Description - More frequent retries for the first ~30 mins, meant to accommodate the upcoming CCIP ISM which is known to take ~25 mins on some origins After this change: ``` Retry #0: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:0 Retry #1: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:10 Retry #2: cumulative duration from beginning is 0:0:10, since last attempt is 0:0:10 Retry #3: cumulative duration from beginning is 0:0:20, since last attempt is 0:0:10 Retry #4: cumulative duration from beginning is 0:0:30, since last attempt is 0:0:10 Retry #5: cumulative duration from beginning is 0:0:40, since last attempt is 0:0:10 Retry #6: cumulative duration from beginning is 0:0:50, since last attempt is 0:0:10 Retry #7: cumulative duration from beginning is 0:1:0, since last attempt is 0:0:10 Retry #8: cumulative duration from beginning is 0:1:10, since last attempt is 0:0:10 Retry #9: cumulative duration from beginning is 0:1:20, since last attempt is 0:0:10 Retry #10: cumulative duration from beginning is 0:1:30, since last attempt is 0:1:30 Retry #11: cumulative duration from beginning is 0:3:0, since last attempt is 0:1:30 Retry #12: cumulative duration from beginning is 0:4:30, since last attempt is 0:1:30 Retry #13: cumulative duration from beginning is 0:6:0, since last attempt is 0:1:30 Retry #14: cumulative duration from beginning is 0:7:30, since last attempt is 0:1:30 Retry #15: cumulative duration from beginning is 0:9:0, since last attempt is 0:2:0 Retry #16: cumulative duration from beginning is 0:11:0, since last attempt is 0:2:0 Retry #17: cumulative duration from beginning is 0:13:0, since last attempt is 0:2:0 Retry #18: cumulative duration from beginning is 0:15:0, since last attempt is 0:2:0 Retry #19: cumulative duration from beginning is 0:17:0, since last attempt is 0:2:0 Retry #20: cumulative duration from beginning is 0:19:0, since last attempt is 0:2:0 Retry #21: cumulative duration from beginning is 0:21:0, since last attempt is 0:2:0 Retry #22: cumulative duration from beginning is 0:23:0, since last attempt is 0:2:0 Retry #23: cumulative duration from beginning is 0:25:0, since last attempt is 0:2:0 Retry #24: cumulative duration from beginning is 0:27:0, since last attempt is 0:2:0 Retry #25: cumulative duration from beginning is 0:29:0, since last attempt is 0:3:0 Retry #26: cumulative duration from beginning is 0:32:0, since last attempt is 0:4:30 Retry #27: cumulative duration from beginning is 0:36:30, since last attempt is 0:6:0 Retry #28: cumulative duration from beginning is 0:42:30, since last attempt is 0:7:30 Retry #29: cumulative duration from beginning is 0:50:0, since last attempt is 0:9:0 Retry #30: cumulative duration from beginning is 0:59:0, since last attempt is 0:10:30 Retry hyperlane-xyz#31: cumulative duration from beginning is 1:9:30, since last attempt is 0:12:0 Retry hyperlane-xyz#32: cumulative duration from beginning is 1:21:30, since last attempt is 0:13:30 Retry hyperlane-xyz#33: cumulative duration from beginning is 1:35:0, since last attempt is 0:15:0 Retry hyperlane-xyz#34: cumulative duration from beginning is 1:50:0, since last attempt is 0:16:30 Retry hyperlane-xyz#35: cumulative duration from beginning is 2:6:30, since last attempt is 0:18:0 Retry hyperlane-xyz#36: cumulative duration from beginning is 2:24:30, since last attempt is 0:19:30 Retry hyperlane-xyz#37: cumulative duration from beginning is 2:44:0, since last attempt is 0:21:0 Retry hyperlane-xyz#38: cumulative duration from beginning is 3:5:0, since last attempt is 0:22:30 Retry hyperlane-xyz#39: cumulative duration from beginning is 3:27:30, since last attempt is 0:24:0 Retry hyperlane-xyz#40: cumulative duration from beginning is 3:51:30, since last attempt is 0:30:0 Retry hyperlane-xyz#41: cumulative duration from beginning is 4:21:30, since last attempt is 0:30:0 Retry hyperlane-xyz#42: cumulative duration from beginning is 4:51:30, since last attempt is 0:30:0 Retry hyperlane-xyz#43: cumulative duration from beginning is 5:21:30, since last attempt is 0:30:0 Retry hyperlane-xyz#44: cumulative duration from beginning is 5:51:30, since last attempt is 0:30:0 Retry hyperlane-xyz#45: cumulative duration from beginning is 6:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#46: cumulative duration from beginning is 7:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#47: cumulative duration from beginning is 8:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#48: cumulative duration from beginning is 9:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#49: cumulative duration from beginning is 10:21:30, since last attempt is 1:0:0 Retry hyperlane-xyz#50: cumulative duration from beginning is 11:21:30, since last attempt is 2:38:56 Retry hyperlane-xyz#51: cumulative duration from beginning is 14:0:26, since last attempt is 8:6:55 Retry hyperlane-xyz#52: cumulative duration from beginning is 22:7:21, since last attempt is 8:24:34 Retry hyperlane-xyz#53: cumulative duration from beginning is 30:31:55, since last attempt is 12:32:21 Retry hyperlane-xyz#54: cumulative duration from beginning is 43:4:16, since last attempt is 15:56:31 Retry hyperlane-xyz#55: cumulative duration from beginning is 59:0:47, since last attempt is 15:29:51 Retry hyperlane-xyz#56: cumulative duration from beginning is 74:30:38, since last attempt is 14:13:18 Retry hyperlane-xyz#57: cumulative duration from beginning is 88:43:56, since last attempt is 16:55:33 Retry hyperlane-xyz#58: cumulative duration from beginning is 105:39:29, since last attempt is 22:51:56 Retry hyperlane-xyz#59: cumulative duration from beginning is 128:31:25, since last attempt is 23:20:42 Retry hyperlane-xyz#60: cumulative duration from beginning is 151:52:7, since last attempt is 24:5:0 Retry hyperlane-xyz#61: cumulative duration from beginning is 175:57:7, since last attempt is 26:51:36 Retry hyperlane-xyz#62: cumulative duration from beginning is 202:48:43, since last attempt is 30:55:26 Retry hyperlane-xyz#63: cumulative duration from beginning is 233:44:9, since last attempt is 32:33:46 Retry hyperlane-xyz#64: cumulative duration from beginning is 266:17:55, since last attempt is 33:58:37 Retry hyperlane-xyz#65: cumulative duration from beginning is 300:16:32, since last attempt is 35:31:14 Retry hyperlane-xyz#66: cumulative duration from beginning is 335:47:46, since last attempt is 38:37:22 Retry hyperlane-xyz#67: cumulative duration from beginning is 374:25:8, since last attempt is 36:1:47 Retry hyperlane-xyz#68: cumulative duration from beginning is 410:26:55, since last attempt is 42:42:1 Retry hyperlane-xyz#69: cumulative duration from beginning is 453:8:56, since last attempt is 42:7:4 Retry hyperlane-xyz#70: cumulative duration from beginning is 495:16:0, since last attempt is 47:45:25 Retry hyperlane-xyz#71: cumulative duration from beginning is 543:1:25, since last attempt is 47:20:15 Retry hyperlane-xyz#72: cumulative duration from beginning is 590:21:40, since last attempt is 50:42:29 Retry hyperlane-xyz#73: cumulative duration from beginning is 641:4:9, since last attempt is 50:36:53 Retry hyperlane-xyz#74: cumulative duration from beginning is 691:41:2, since last attempt is 53:25:8 Retry hyperlane-xyz#75: cumulative duration from beginning is 745:6:10, since last attempt is 54:32:25 Retry hyperlane-xyz#76: cumulative duration from beginning is 799:38:35, since last attempt is 55:46:58 Retry hyperlane-xyz#77: cumulative duration from beginning is 855:25:33, since last attempt is 59:21:28 Retry hyperlane-xyz#78: cumulative duration from beginning is 914:47:1, since last attempt is 58:47:29 Retry hyperlane-xyz#79: cumulative duration from beginning is 973:34:30, since last attempt is 63:38:16 Retry hyperlane-xyz#80: cumulative duration from beginning is 1037:12:46, since last attempt is 64:29:15 Retry hyperlane-xyz#81: cumulative duration from beginning is 1101:42:1, since last attempt is 66:44:38 Retry hyperlane-xyz#82: cumulative duration from beginning is 1168:26:39, since last attempt is 67:13:25 Retry hyperlane-xyz#83: cumulative duration from beginning is 1235:40:4, since last attempt is 71:38:16 Retry hyperlane-xyz#84: cumulative duration from beginning is 1307:18:20, since last attempt is 70:59:58 Retry hyperlane-xyz#85: cumulative duration from beginning is 1378:18:18, since last attempt is 73:16:27 Retry hyperlane-xyz#86: cumulative duration from beginning is 1451:34:45, since last attempt is 75:50:17 Retry hyperlane-xyz#87: cumulative duration from beginning is 1527:25:2, since last attempt is 80:23:55 Retry hyperlane-xyz#88: cumulative duration from beginning is 1607:48:57, since last attempt is 81:41:11 Retry hyperlane-xyz#89: cumulative duration from beginning is 1689:30:8, since last attempt is 83:48:29 Retry hyperlane-xyz#90: cumulative duration from beginning is 1773:18:37, since last attempt is 82:24:16 Retry hyperlane-xyz#91: cumulative duration from beginning is 1855:42:53, since last attempt is 88:31:19 Retry hyperlane-xyz#92: cumulative duration from beginning is 1944:14:12, since last attempt is 88:53:21 Retry hyperlane-xyz#93: cumulative duration from beginning is 2033:7:33, since last attempt is 91:55:18 Retry hyperlane-xyz#94: cumulative duration from beginning is 2125:2:51, since last attempt is 90:38:51 Retry hyperlane-xyz#95: cumulative duration from beginning is 2215:41:42, since last attempt is 96:53:4 Retry hyperlane-xyz#96: cumulative duration from beginning is 2312:34:46, since last attempt is 96:9:40 Retry hyperlane-xyz#97: cumulative duration from beginning is 2408:44:26, since last attempt is 99:26:42 Retry hyperlane-xyz#98: cumulative duration from beginning is 2508:11:8, since last attempt is 98:48:58 Retry hyperlane-xyz#99: cumulative duration from beginning is 2607:0:6, since last attempt is 102:43:45 ``` Before: ``` 0: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:0 1: cumulative duration from beginning is 0:0:0, since last attempt is 0:0:10 2: cumulative duration from beginning is 0:0:10, since last attempt is 0:0:10 3: cumulative duration from beginning is 0:0:20, since last attempt is 0:0:10 4: cumulative duration from beginning is 0:0:30, since last attempt is 0:0:10 5: cumulative duration from beginning is 0:0:40, since last attempt is 0:0:10 6: cumulative duration from beginning is 0:0:50, since last attempt is 0:0:10 7: cumulative duration from beginning is 0:1:0, since last attempt is 0:0:10 8: cumulative duration from beginning is 0:1:10, since last attempt is 0:0:10 9: cumulative duration from beginning is 0:1:20, since last attempt is 0:0:10 10: cumulative duration from beginning is 0:1:30, since last attempt is 0:0:10 11: cumulative duration from beginning is 0:1:40, since last attempt is 0:0:10 12: cumulative duration from beginning is 0:1:50, since last attempt is 0:1:30 13: cumulative duration from beginning is 0:3:20, since last attempt is 0:3:0 14: cumulative duration from beginning is 0:6:20, since last attempt is 0:4:30 15: cumulative duration from beginning is 0:10:50, since last attempt is 0:6:0 16: cumulative duration from beginning is 0:16:50, since last attempt is 0:7:30 17: cumulative duration from beginning is 0:24:20, since last attempt is 0:9:0 18: cumulative duration from beginning is 0:33:20, since last attempt is 0:10:30 19: cumulative duration from beginning is 0:43:50, since last attempt is 0:12:0 20: cumulative duration from beginning is 0:55:50, since last attempt is 0:13:30 21: cumulative duration from beginning is 1:9:20, since last attempt is 0:15:0 22: cumulative duration from beginning is 1:24:20, since last attempt is 0:16:30 23: cumulative duration from beginning is 1:40:50, since last attempt is 0:18:0 24: cumulative duration from beginning is 1:58:50, since last attempt is 0:30:0 25: cumulative duration from beginning is 2:28:50, since last attempt is 0:30:0 26: cumulative duration from beginning is 2:58:50, since last attempt is 0:30:0 27: cumulative duration from beginning is 3:28:50, since last attempt is 0:30:0 28: cumulative duration from beginning is 3:58:50, since last attempt is 0:30:0 29: cumulative duration from beginning is 4:28:50, since last attempt is 0:30:0 ``` ### Drive-by changes  ### Related issues  ### Backward compatibility  ### Testing

mortezashojaei and others added 12 commits October 16, 2024 15:07

merge with main repo latest changes

dedaa34

Merge remote-tracking branch 'origin-root/main'

4f541e3

Merge remote-tracking branch 'origin-root/main'

f10e542

Merge remote-tracking branch 'origin-root/main'

36e2b00

feat: Singe/MultiVM signer strategy

ba0d6ea

feat: Deployment strategies & refactoring

2bf349b

fix: e2e test working

9c43d1c

chore: add comments & minor refactoring

3602abd

chore: minor fixes

ce81b48

Merge remote-tracking branch 'origin-root/main'

ff2b4c9

Merge remote-tracking branch 'origin-root/main'

af97d7f

perf: removed unused code and refactoring

e4839a1

ltyu reviewed Nov 12, 2024

View reviewed changes

ljankovic-txfusion commented Nov 13, 2024

View reviewed changes

feat: masked pk, refactoring

4abd806

mshojaei-txfusion force-pushed the main branch from ff2b4c9 to 1866635 Compare November 14, 2024 10:10

ljankovic-txfusion added 4 commits November 14, 2024 14:21

feat: MultiChainHandler support to extract chains from WarpCoreConfig…

188dced

… file

chore: refactoring & adding comments

0b92c68

Merge remote-tracking branch 'origin/main' into feat/key-command

ea205dc

feat: relay command chain resolver strategy & refactoring

ac6d5c1

ljankovic-txfusion changed the title ~~Feat/strategy command~~ feat: evm multi chain signer Nov 15, 2024

ljankovic-txfusion added 7 commits November 18, 2024 13:57

feat: Signer strategy based on chain's protocol/tech stack

925621c

chore: minor refactoring

a0ea88b

Merge remote-tracking branch 'origin/main' into feat/key-command

f030f23

add: strategy types for submitter

52efa81

chore: following naming conventions & comments

12679af

feat: requiresKey options on strategy read command

b7d439b

chore: revert MessageOptionsArgTypes origin & destination optionality

24b9d7a

ljankovic-txfusion and others added 28 commits November 25, 2024 17:53

fix: passed key used for setting signer

e61baff

Merge remote-tracking branch 'origin/main' into feat/key-command

2d08d1e

fix: update getWarpCoreConfigOrExit import on MultiChainResolver

92115c0

Merge remote-tracking branch 'origin-root/main'

c6cc7e9

Merge remote-tracking branch 'origin-root/main' into feat/key-command

0c8dc01

fix: no-unused-vars linting issues

ccc7df6

minor: remove catch unused param

bdf0107

Merge branch 'hyperlane-xyz:main' into main

e13e08a

Merge branch 'hyperlane-xyz:main' into main

0546e10

Merge branch 'hyperlane-xyz:main' into main

2ee37d4

Merge branch 'hyperlane-xyz:main' into main

7770bd7

fix: read multiProtocolSigner from sginer middleware on warp init

21758af

refactor: standardize signer address handling on context

38310f8

feat(cli): Add 'check' command to SIGN_COMMANDS and use signer for co…

6e437c7

…ntext multiprovider

fix: handle warp check as a sign command on signer strategies

4820623

fix: handle warp read and warp check as sign command temporary

3146e93

chore: fix typo

fa2b0e8

Merge branch 'hyperlane-xyz:main' into main

7d6a156

Merge branch 'hyperlane-xyz:main' into main

b90d0f7

Merge branch 'main' into feat/key-command

80533e1

chore: modify type of signer on context

4e3b65c

fix: remove unused variables

e5a63c9

Merge branch 'hyperlane-xyz:main' into main

c33d90f

Merge branch 'main' into feat/key-command

7bf044f

fix: resolve chais when there is remoteIcaRouters on core apply

96322c5

refactor(resolver): enhance core apply chains resolution with EvmCore…

1eb69e9

…Module

Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…

676f22a

…to feat/key-command

feat(sdk): add optional userAddress and privateKey to JsonRpcTxSubmit…

bae0f81

…ter props

ljankovic-txfusion force-pushed the main branch from db616cc to f1745f9 Compare February 20, 2025 15:10

Conversation

ljankovic-txfusion commented Nov 12, 2024

Uh oh!

ltyu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants