-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redis scan command support #678
Open
lukemakeit
wants to merge
7
commits into
twitter:master
Choose a base branch
from
lukemakeit:add-scan-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fa1a7a7
redis script command support
lukemakeit 6e45af7
redis scan command support
lukemakeit 4ed8a9e
Apply suggestions from code review
lukemakeit b6e9807
Apply suggestions from code review
lukemakeit 3f904e2
Merge pull request #1 from lukemakeit/add-script-support
lukemakeit 6d3304f
Merge branch 'master' of https://github.com/lukexwang/twemproxy into …
lukemakeit 758cb66
fix a scan bug and update readme
lukemakeit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -700,12 +700,18 @@ server_pool_idx(const struct server_pool *pool, const uint8_t *key, uint32_t key | |
} | ||
|
||
static struct server * | ||
server_pool_server(struct server_pool *pool, const uint8_t *key, uint32_t keylen) | ||
server_pool_server(struct server_pool *pool, struct msg *r, const uint8_t *key, uint32_t keylen) | ||
{ | ||
struct server *server; | ||
uint32_t idx; | ||
|
||
idx = server_pool_idx(pool, key, keylen); | ||
if (r->type == MSG_REQ_REDIS_SCAN) { | ||
idx = r->server_index; | ||
}else if (r->type == MSG_REQ_REDIS_SCRIPT) { | ||
idx = r->server_index; | ||
} else { | ||
idx = server_pool_idx(pool, key, keylen); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change the cursor of request in |
||
server = array_get(&pool->server, idx); | ||
|
||
log_debug(LOG_VERB, "key '%.*s' on dist %d maps to server '%.*s'", keylen, | ||
|
@@ -715,8 +721,7 @@ server_pool_server(struct server_pool *pool, const uint8_t *key, uint32_t keylen | |
} | ||
|
||
struct conn * | ||
server_pool_conn(struct context *ctx, struct server_pool *pool, const uint8_t *key, | ||
uint32_t keylen) | ||
server_pool_conn(struct context *ctx, struct server_pool *pool, struct msg *msg, const uint8_t *key, uint32_t keylen) | ||
{ | ||
rstatus_t status; | ||
struct server *server; | ||
|
@@ -728,7 +733,7 @@ server_pool_conn(struct context *ctx, struct server_pool *pool, const uint8_t *k | |
} | ||
|
||
/* from a given {key, keylen} pick a server from pool */ | ||
server = server_pool_server(pool, key, keylen); | ||
server = server_pool_server(pool, msg, key, keylen); | ||
if (server == NULL) { | ||
return NULL; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is not clear enough. how about this one:
the server index which the requstion should be forwarded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok