Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Scrooge to be compatible with the ENUM representation changes introduced in Thrift 0.19.0 (link here), while maintaining backward compatibility with older Thrift versions.
Key changes:
TLazyBinaryProtocol
to recognize and handle the new ENUM type identifier (-1) introduced in Thrift 0.19.0:readFieldBegin
to correctly interpret the new ENUM type identifier.writeFieldBegin
to use the new ENUM type identifier when writing ENUM fields.These changes ensure that Scrooge can correctly read and write ENUM types when working with Thrift 0.19.0, while still maintaining compatibility with older Thrift versions that use the previous ENUM type identifier (16).
Testing: