Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post request in http body #161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

post request in http body #161

wants to merge 1 commit into from

Conversation

pjw91
Copy link

@pjw91 pjw91 commented Mar 12, 2025

No description provided.

@Emilgardis
Copy link
Member

Why this change? It works fine as is

@Nerixyz
Copy link
Contributor

Nerixyz commented Mar 12, 2025

Why this change? It works fine as is

This is the way it's explained in the docs. For some reason, passing the parameters in the URL works too.

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the way twitch says to do it, lets do it that way

Thank you!

@Emilgardis
Copy link
Member

Do we think a changelog entry is needed?

@Nerixyz
Copy link
Contributor

Nerixyz commented Mar 12, 2025

Do we think a changelog entry is needed?

At least a Changed entry should be good.


I think we should change construct_request (could be done in another PR). We should rename params to body and treat them as a body (if the request isn't GET). The old body should be removed (it's not used). The only API that explicitly shows request parameters is the mock API. But they parse the body as well (Twitch probably does the same).


Aside: @pjw91 creating pull requests from the default branch (main/master) is an anti-pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants