easy refresh #160
Merged
easy refresh #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
force-pushed
the
easy-refresh
branch
2 times, most recently
from
7ed3d5c to
ba2fc21
Compare
Nerixyz
reviewed
Mar 5, 2025
src/tokens/user_token.rs
Outdated
| @@ -150,6 +173,47 @@ impl UserToken { | |||
| .map_err(|e| e.into_other()) | |||
| } | |||
|
|
|||
| /// Create a [UserToken] from an existing active user token or refresh token if the access token is expired. Retrieves [`login`](TwitchToken::login), [`client_id`](TwitchToken::client_id) and [`scopes`](TwitchToken::scopes) | |||
There was a problem hiding this comment.
Suggested change
| /// Create a [UserToken] from an existing active user token or refresh token if the access token is expired. Retrieves [`login`](TwitchToken::login), [`client_id`](TwitchToken::client_id) and [`scopes`](TwitchToken::scopes) | |
| /// Create a [UserToken] from an existing active user token or refresh token if the access token is expired. Retrieves [`login`](TwitchToken::login), [`client_id`](TwitchToken::client_id) and [`scopes`](TwitchToken::scopes). |
src/tokens/user_token.rs
Outdated
| @@ -112,9 +112,32 @@ impl UserToken { | |||
| Self::from_existing(http_client, access_token, None, None).await | |||
| } | |||
|
|
|||
| /// Create a [UserToken] from a refresh token. Retrieves [`login`](TwitchToken::login), [`client_id`](TwitchToken::client_id) and [`scopes`](TwitchToken::scopes) | |||
There was a problem hiding this comment.
Suggested change
| /// Create a [UserToken] from a refresh token. Retrieves [`login`](TwitchToken::login), [`client_id`](TwitchToken::client_id) and [`scopes`](TwitchToken::scopes) | |
| /// Create a [UserToken] from a refresh token. Retrieves [`login`](TwitchToken::login), [`client_id`](TwitchToken::client_id) and [`scopes`](TwitchToken::scopes). |
I think this should mention that it refreshes the token. Afaik, the passed token doesn't become invalid, but it's better to save the new refresh token.
There was a problem hiding this comment.
Was considering adding it but then decided against it. But if you think it should be there I'll agree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #158