This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
fixes #976: saving tweets to csv #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the issue caused by twintproject#967, which broke the functionality of saving the retrieved data into a csv file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue caused by #967, which broke the functionality of saving the retrieved data into a csv file.
#967 added the functionality of saving the tweets to csv with
tabsinstead of,but didn't handle the case when--tabsis not provided in the command line. which would later throw anAttributeErrorin write.py.This patch fixes the following issues:
#990
#983
#976
Although I have merged this branch into my master, which already have a PR on the project, I'll still keep this PR because this problem has a higher priority, and is fixed simply by changing a line.
Thus this can be merged much quickly into the twintproject:master, whereas my master has a lot of fixes and a lot of code has changed in it so it might take some time for that to get checked and eventually get merged.
In the meantime merging this into the project would provide a quick fix to people who are not being able to save the results to csv.