Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid deprecation messages for PHP 8.4 #834

Merged
merged 8 commits into from
Jan 8, 2025
Merged

fix: avoid deprecation messages for PHP 8.4 #834

merged 8 commits into from
Jan 8, 2025

Conversation

phpfui
Copy link
Contributor

@phpfui phpfui commented Nov 22, 2024 •
edited by tiwarishubham635
Loading

Fixes

This PR makes the minimal changes needed to avoid depreciation messages for PHP 8.4. It does not contain any logic changes:

  • Removes E_STRING in tests/bootstrap.php
  • Add ? to parameter types that default to null
  • Make explict $value property in \Twilio\TwiML\GenericNode

All changes should be compatible with PHP 7.1, which is the lowest supported PHP version.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@phpfui
Copy link
Contributor Author

phpfui commented Dec 3, 2024

Is there anything I need to do to get this merged?

Thanks.

phpfui added 2 commits December 5, 2024 11:44
@phpfui
Merge branch 'main' into PHP8.4
a356783
@phpfui
Revert "assertObjectNotHasAttribute to assertObjectNotHasProperty"
a36234c 
This reverts commit aa90ec7.
fix: Reverted depreciation change for PHPUnit
fix: PHP 8.4 support added
@oojacoboo
Copy link

Be nice to get this merged in and versioned. Anyone that isn't ignoring deprecations will be blocked from using 8.4

@bobahvas bobahvas mentioned this pull request Dec 23, 2024
Open
@oojacoboo
Copy link

@phpfui can you get the tests passing here? I don't know what's up with the Twilio team - guess still on vacation...

@phpfui phpfui changed the title Php8.4 fix - Php8.4 Jan 7, 2025
@phpfui phpfui changed the title fix - Php8.4 Fix: Php8.4 Jan 7, 2025
@phpfui phpfui changed the title Fix: Php8.4 fix: Php8.4 Jan 7, 2025
@phpfui
Copy link
Contributor Author

phpfui commented Jan 7, 2025

I have not seen this prefix thing before, but looks like it works now.

Can we get a merge here to support 8.4? PHP 8.4 was released two months ago.

@tiwarishubham635
Copy link
Contributor

Hi! Let me review this once

tiwarishubham635
tiwarishubham635 reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look more or less good to me. Can you please verify once of the places where ? needs to be added? Also, do we really need to give ?string $contentType = null, or can we straightaway write ?string $contentType and use nullable types? Please check once

@oojacoboo
Copy link

Also, please add PHP 8.4 to the test-suite. Based on my comment above, I suspect the deprecations are not fully resolved.

@phpfui
Copy link
Contributor Author

phpfui commented Jan 7, 2025

I did not see any other depreciations when running PHPUnit with PHP 8.4, so I think we are good assuming your tests have 100% code coverage.

tiwarishubham635
tiwarishubham635 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tiwarishubham635 tiwarishubham635 changed the title fix: Php8.4 fix: avoid deprecation messages for PHP 8.4 Jan 8, 2025
@tiwarishubham635 tiwarishubham635 merged commit 6753a82 into twilio:main Jan 8, 2025
21 checks passed
@tiwarishubham635 tiwarishubham635 mentioned this pull request Jan 8, 2025
Merged
8 tasks
@tiwarishubham635
Copy link
Contributor

Reverted these changes due to failing tests - https://github.com/twilio/twilio-php/actions/runs/12664947059/job/35293855625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oojacoboo oojacoboo oojacoboo left review comments

@jarebear6expepjozn6rakjq5iczi3irqwphcvb jarebear6expepjozn6rakjq5iczi3irqwphcvb jarebear6expepjozn6rakjq5iczi3irqwphcvb approved these changes

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phpfui @oojacoboo @tiwarishubham635 @jarebear6expepjozn6rakjq5iczi3irqwphcvb