Skip to content

chore: go fix for path params #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025
Merged

chore: go fix for path params #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecb795f
chore: go fix for path params
manisha1997 Feb 18, 2025
4cf1f07
chore: go fix for path params
manisha1997 Feb 18, 2025
b538790
Merge branch 'main' into dii-1819
manisha1997 Feb 18, 2025
9b642dd
Merge branch 'main' into dii-1819
manisha1997 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/go/go-client/helper/rest/api/v2010/accounts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import (
"encoding/json"
"fmt"
"net/url"
"strings"
"time"

"github.com/twilio/twilio-go/client"
)
Expand Down
3 changes: 2 additions & 1 deletion examples/go/go-client/helper/rest/api/v2010/accounts_calls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import (
"encoding/json"
"fmt"
"net/url"
"strings"

"github.com/twilio/twilio-go/client"
)

// Optional parameters for the method 'CreateCall'
Expand Down
3 changes: 2 additions & 1 deletion examples/go/go-client/helper/rest/api/v2010/accounts_calls_feedback_summary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import (
"encoding/json"
"fmt"
"net/url"
"strings"

"github.com/twilio/twilio-go/client"
)

// Optional parameters for the method 'UpdateCallFeedbackSummary'
Expand Down
5 changes: 5 additions & 0 deletions examples/go/go-client/helper/rest/api/v2010/model_list_account_response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

package openapi

import (
"encoding/json"
"github.com/twilio/twilio-go/client"
)

// ListAccountResponse struct for ListAccountResponse
type ListAccountResponse struct {
End int `json:"end,omitempty"`
Expand Down
5 changes: 5 additions & 0 deletions examples/go/go-client/helper/rest/api/v2010/model_list_health_check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

package openapi

import (
"encoding/json"
"github.com/twilio/twilio-go/client"
)

// ListHealthCheck struct for ListHealthCheck
type ListHealthCheck struct {
Status []string `json:"status,omitempty"`
Expand Down
1 change: 0 additions & 1 deletion examples/go/go-client/helper/rest/api/v2010/model_test_response_object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package openapi

import (
"encoding/json"

"github.com/twilio/twilio-go/client"
)

Expand Down
1 change: 0 additions & 1 deletion ...es/go/go-client/helper/rest/api/v2010/model_test_response_object_test_array_of_objects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package openapi

import (
"encoding/json"

"github.com/twilio/twilio-go/client"
)

Expand Down
5 changes: 5 additions & 0 deletions examples/go/go-client/helper/rest/api/v2010/model_test_response_object_test_object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

package openapi

import (
"encoding/json"
"github.com/twilio/twilio-go/client"
)

// TestResponseObjectTestObject struct for TestResponseObjectTestObject
type TestResponseObjectTestObject struct {
Fax bool `json:"fax,omitempty"`
Expand Down
2 changes: 0 additions & 2 deletions examples/go/go-client/helper/rest/flex/v1/credentials_aws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import (
"encoding/json"
"fmt"
"net/url"
"strings"
"time"

"github.com/twilio/twilio-go/client"
)
Expand Down
4 changes: 3 additions & 1 deletion examples/go/go-client/helper/rest/flex/v1/credentials_aws_history.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ package openapi

import (
"encoding/json"
"fmt"
"net/url"
"strings"

"github.com/twilio/twilio-go/client"
)

// Optional parameters for the method 'FetchCredentialHistory'
Expand Down
5 changes: 5 additions & 0 deletions examples/go/go-client/helper/rest/flex/v1/model_list_credential_aws_response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

package openapi

import (
"encoding/json"
"github.com/twilio/twilio-go/client"
)

// ListCredentialAwsResponse struct for ListCredentialAwsResponse
type ListCredentialAwsResponse struct {
Credentials []TestResponseObject `json:"credentials,omitempty"`
Expand Down
5 changes: 5 additions & 0 deletions examples/go/go-client/helper/rest/flex/v1/model_list_credential_aws_response_meta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

package openapi

import (
"encoding/json"
"github.com/twilio/twilio-go/client"
)

// ListCredentialAwsResponseMeta struct for ListCredentialAwsResponseMeta
type ListCredentialAwsResponseMeta struct {
FirstPageUrl string `json:"first_page_url,omitempty"`
Expand Down
5 changes: 5 additions & 0 deletions examples/go/go-client/helper/rest/flex/v1/model_test_response_object.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

package openapi

import (
"encoding/json"
"github.com/twilio/twilio-go/client"
)

// TestResponseObject struct for TestResponseObject
type TestResponseObject struct {
AccountSid *string `json:"account_sid,omitempty"`
Expand Down
5 changes: 5 additions & 0 deletions examples/go/go-client/helper/rest/flex/v1/model_update_call_response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

package openapi

import (
"encoding/json"
"github.com/twilio/twilio-go/client"
)

// UpdateCallResponse struct for UpdateCallResponse
type UpdateCallResponse struct {
// Non-string path parameter in the response.
Expand Down
4 changes: 3 additions & 1 deletion examples/go/go-client/helper/rest/flex/v1/voice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ package openapi

import (
"encoding/json"
"fmt"
"net/url"
"strings"

"github.com/twilio/twilio-go/client"
)

func (c *ApiService) UpdateCall(Sid string) (*UpdateCallResponse, error) {
Expand Down
7 changes: 2 additions & 5 deletions examples/go/go-client/terraform/resources/api/v2010/api_default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,11 @@ package openapi

import (
"context"
"fmt"
. "go-client/helper/rest/api/v2010"
"go-client/terraform/client"
"strings"

"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
. "github.com/twilio/terraform-provider-twilio/core"
. "go-client/helper/rest/api/v2010"
"go-client/terraform/client"
)

func ResourceAccounts() *schema.Resource {
Expand Down
7 changes: 2 additions & 5 deletions examples/go/go-client/terraform/resources/flex/v1/api_default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,11 @@ package openapi

import (
"context"
"fmt"
. "go-client/helper/rest/flex/v1"
"go-client/terraform/client"
"strings"

"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
. "github.com/twilio/terraform-provider-twilio/core"
. "go-client/helper/rest/flex/v1"
"go-client/terraform/client"
)

func ResourceCredentialsAWS() *schema.Resource {
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/twilio-go/partial_serialization.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if params != nil && params.PathAccountSid != nil {
{{/vendorExtensions.x-is-account-sid}}
{{/queryParams}}
{{#pathParams}}
path = strings.Replace(path, "{"+"{{paramName}}"+"}", {{^isString}}fmt.Sprint({{/isString}}{{paramName}}{{^isString}}){{/isString}}, -1)
path = strings.Replace(path, "{"+"{{baseName}}"+"}", {{^isString}}fmt.Sprint({{/isString}}{{paramName}}{{^isString}}){{/isString}}, -1)
{{/pathParams}}

data := url.Values{}
Expand Down
Loading