feat: MenuItem disabled color #9923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves the visibility of disabled menu items by replacing opacity-based styling with direct color changes and removing the chevron icon when disabled.
- Modified
packages/twenty-ui/src/navigation/menu-item/internals/components/StyledMenuItemBase.tsxto remove opacity:0.4 styling in favor of theme.font.color.tertiary - Updated
packages/twenty-ui/src/navigation/menu-item/components/MenuItem.tsxto hide chevron right icon for disabled items - Changed
packages/twenty-ui/src/navigation/menu-item/internals/components/MenuItemLeftContent.tsxto use theme.font.color.light instead of hardcoded gray35 - Renamed
isDisabledprop todisabledacross components for consistency
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+46
to
+50
| if (!isUndefined(disabled) && disabled !== false) { | ||
| return css` | ||
| color: ${theme.font.color.tertiary}; | ||
| `; | ||
| } |
There was a problem hiding this comment.
style: The disabled check !isUndefined(disabled) && disabled !== false could be simplified to just disabled === true for better readability and to prevent edge cases.
eliezer-rodrigues037
pushed a commit
to mind-developer/kvoip-v2
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9874