Fix:Empty link in record details isn't deleted by default

[Lucifer4255]

Gives a fix for #9780 . I have added handleDelete inside the submit function and created a state to manage the empty placeholder
Screencast from 2025-01-24 01-45-22.webm

[greptile-apps]

PR Summary

This PR adds functionality to handle empty link deletion in record details, ensuring that empty links are properly removed when a user clears the input field.

• Added isClearingInput state in MultiItemFieldInput.tsx to track input clearing status
• Modified handleSubmitInput to trigger item deletion when input is cleared
• Improved empty string validation using turnIntoEmptyStringIfWhitespacesOnly utility
• Integrated with existing link field components to maintain consistent behavior

_{1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile}

[etiennejouan]

Hi @Lucifer4255, thank you for your PR.

Your solution is not handling case where input is empty string (without update).

I would handle empty string input in handleSubmitInput method.

• If inputValue is empty string AND isAddingNewItem, it should early return
• If inputValue is empty string AND !isAddingNewItem, it should delete updated item and early return

[etiennejouan]

@Lucifer4255 thank you for your update, added few comments.

[prastoin]

Sounds good to me !
Shouldn't the API reject empty value for objectMetadata field links ? What kind of server side validation do we wanna reach to on objectMetadaItem fields ?

[github-actions]

	Fails
🚫	node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token < in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5591:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5562:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5571:7)�[39m
danger-results://tmp/danger-results-dab24ed0.json

Generated by 🚫 dangerJS against 3ff3710