fix: date input click outside #9676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbordeau
approved these changes
Jan 16, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved click-outside detection for the DateInput component by implementing pixel-based comparison and adding dropdown focus ID validation.
- Added
ClickOutsideMode.comparePixelsinDateInput.tsxfor more accurate click detection based on pixel coordinates - Implemented dropdown focus ID validation in
useRegisterInputEvents.tsto prevent unwanted click-outside triggers - Added debug mode and improved logging in
useListenClickOutside.tsfor better troubleshooting - Refactored click detection logic using switch statements for cleaner mode handling
- Added proper dependency tracking for
listenerIdinuseListenClickOutside.ts
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
...ront/src/modules/object-record/record-field/meta-types/input/hooks/useRegisterInputEvents.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/useListenClickOutside.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9486
This PR fixes a latent bug that was caused by the recent dropdown focus id refactor. It was correctly implemented for dropdowns but not for places where we manually open and close dropdown-like components that also uses a useListenClickoutside.
This was the case for table cells and inline cells.