Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message #9646

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix error message #9646

merged 1 commit into from
Jan 15, 2025
+1 −1

Conversation

martmull
Copy link
Contributor

  • fix typo

@martmull martmull linked an issue Jan 15, 2025 that may be closed by this pull request
REST API problems v2 #7657
Open
greptile-apps[bot]
greptile-apps bot reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed a typo in the error message within RelationMetadataService where "Can't" was incorrectly written as "Can" when throwing a RelationMetadataException.

  • Updated error message in /packages/twenty-server/src/engine/metadata-modules/relation-metadata/relation-metadata.service.ts for better readability

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

bosiraphael
bosiraphael approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martmull martmull enabled auto-merge (squash) January 15, 2025 16:26
@Devessier Devessier self-requested a review January 15, 2025 16:28
Devessier
Devessier approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! We can merge.

@martmull martmull merged commit b5c5bee into main Jan 15, 2025
34 checks passed
@martmull martmull deleted the 7657-rest-api-problems-v2 branch January 15, 2025 16:29
Weiko
Weiko reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@Weiko Weiko Weiko left review comments

@bosiraphael bosiraphael bosiraphael approved these changes

@Devessier Devessier Devessier approved these changes

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REST API problems v2
5 participants
@martmull @Weiko @charlesBochet @Devessier @bosiraphael