Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty link in record details isn't deleted by default #9780

Open
BOHEUS opened this issue Jan 21, 2025 · 5 comments
Open

Empty link in record details isn't deleted by default #9780

BOHEUS opened this issue Jan 21, 2025 · 5 comments
Assignees
@Lucifer4255
Labels
for experienced contributor good first issue Good for newcomers

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Jan 21, 2025

Scenario:

  1. Log in
  2. Go to People
  3. Check details of any record
  4. Add any link
  5. Edit added link and delete whole content, accept

Actual: Empty link is saved

Screencast.From.2025-01-21.20-43-15.mp4

Expected: Empty link should be deleted
@FelixMalfait
Copy link
Member

Good point! We should fix this 👍

@yadavshubham01
Copy link
Contributor

hey @FelixMalfait i want to work on this issue ??

@Lucifer4255
Copy link
Contributor

Can i work on this issue @BOHEUS @FelixMalfait

@Lucifer4255
Copy link
Contributor

Lucifer4255 commented Jan 23, 2025 •
edited
Loading

https://github.com/user-attachments/assets/0382e72b-d7e2-448b-b2b2-73054a29bcae
I think i have solved this issue . Can i Raise a PR for this?
@FelixMalfait

@FelixMalfait
Copy link
Member

Hey @Lucifer4255 yes please! Thanks

@Lucifer4255 Lucifer4255 mentioned this issue Jan 24, 2025
Merged
prastoin pushed a commit that referenced this issue Feb 4, 2025
@Lucifer4255 @etiennejouan
Fix:Empty link in record details isn't deleted by default (#9840)
0675017 
Gives a fix for #9780 . I have added handleDelete inside the submit
function and created a state to manage the empty placeholder
[Screencast from 2025-01-24
01-45-22.webm](https://github.com/user-attachments/assets/87b209a0-7f60-4d72-ad06-c8b955cf6cd2)

---------

Co-authored-by: etiennejouan <[email protected]>
Co-authored-by: Etienne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lucifer4255 Lucifer4255

Labels
for experienced contributor good first issue Good for newcomers
Projects
🎯 Roadmap & Sprints
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FelixMalfait @Lucifer4255 @BOHEUS @yadavshubham01