Made attachments serve via URL instead of embedding them in the JSON response#139
Open
Servus-Altissimi wants to merge 2 commits intotweedegolf:mainfrom
Open
Made attachments serve via URL instead of embedding them in the JSON response#139Servus-Altissimi wants to merge 2 commits intotweedegolf:mainfrom
Servus-Altissimi wants to merge 2 commits intotweedegolf:mainfrom
Conversation
…ding them in the JSON response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Issue 126 Large attachments and raw message bytes were being base64 encoded directly into the
GET /api/message/{id}JSON response. This isn't an issue for smaller files, but larger attachments caused the UI to freeze, as the browser had to deserialize it all.Hence I made the following changes:
/api/message/{id}/attachment/{index}endpoint(cid:)images in HTML emails are rewritten to use the attachment endpointI haven't bumped cargo version.