Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 0.17 #1981

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Prepare release 0.17 #1981

merged 4 commits into from
Oct 19, 2023

Conversation

avdv
Copy link
Member

@avdv avdv commented Oct 18, 2023

Resolves #1975

@avdv avdv force-pushed the release-0.17 branch 4 times, most recently from e6dbad8 to aab0caf Compare October 19, 2023 06:09
@avdv avdv force-pushed the release-0.17 branch 2 times, most recently from 81d630b to b8f8631 Compare October 19, 2023 06:13
@avdv avdv marked this pull request as ready for review October 19, 2023 06:17
@avdv avdv requested a review from aherrmann October 19, 2023 06:17
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few parts in the code using the version number 0.16 (some are false positives, but some are legitimate)

$ rg -l '0\.16'
MODULE.bazel
haskell/asterius/npm/pnpm-lock.yaml
examples/MODULE.bazel
WORKSPACE
logo/vertical.svg
logo/horizontal.svg
rules_haskell_tests/MODULE.bazel
tutorial/MODULE.bazel
rules_haskell_tests/tests/bzlmod_runfiles/other_module/MODULE.bazel
CHANGELOG.md
rules_haskell_nix/MODULE.bazel
registry/modules/rules_haskell_nix/metadata.json
registry/modules/rules_haskell/metadata.json
vendor/bazel_json/test/json_parse_test_data.bzl

Apart from that LGTM!

@avdv avdv force-pushed the release-0.17 branch 2 times, most recently from 7e7554e to 6e255c8 Compare October 19, 2023 07:48
@avdv
Copy link
Member Author

avdv commented Oct 19, 2023

There are still a few parts in the code using the version number 0.16

Good catch! I also added an item to the release issue template, so this is done the next time too.

- update module version to 0.17 and rename modules in local registry

- remove sha256 hash in `start` script and `docs/haskell-use-cases`.
@avdv avdv merged commit 4fc910e into master Oct 19, 2023
@avdv avdv deleted the release-0.17 branch October 19, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare release 0.17
2 participants