test(llm): add tests for _augment_outline_with_ids with frontmatter #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive unit tests for _augment_outline_with_ids() to verify it correctly handles: - Simple journal entries without frontmatter - Journals with frontmatter (date, tags properties) - Nested block hierarchies - Preservation of existing id:: properties These tests prevent regressions when the logseq-outline-parser package is updated but not reinstalled in development environments. The function requires the updated generate_full_context() signature that accepts frontmatter as the fourth parameter. Fixes TypeError when extracting from journals with frontmatter: TypeError: generate_full_context() takes from 2 to 3 positional arguments but 4 were given Assisted-by: Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 84.69% 84.69%
=======================================
Files 48 48
Lines 5137 5137
=======================================
Hits 4351 4351
Misses 786 786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive unit tests for _augment_outline_with_ids() to verify it correctly handles:
These tests prevent regressions when the logseq-outline-parser package is updated but not reinstalled in development environments. The function requires the updated generate_full_context() signature that accepts frontmatter as the fourth parameter.
Fixes TypeError when extracting from journals with frontmatter:
TypeError: generate_full_context() takes from 2 to 3 positional arguments
but 4 were given
Assisted-by: Claude Code