Skip to content

Commit

Permalink
Remove commented out MSSQL Stuff
Browse files Browse the repository at this point in the history
Cleanup the Dockerfile
  • Loading branch information
tuxpeople authored May 31, 2021
1 parent 82511a8 commit 29c36c7
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@

FROM alpine:3.13.5

# MSSQL_VERSION can be changed, by passing `--build-arg MSSQL_VERSION=<new version>` during docker build
# $(curl -s https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-ver15 | grep "verify" | grep msodbcsql17 | awk '{ print $3}' | cut -d'_' -f2)
#ARG MSSQL_VERSION=17.6.1.1-1
#ENV MSSQL_VERSION=${MSSQL_VERSION}

# Resolve DL4006 https://github.com/hadolint/hadolint/wiki/DL4006
SHELL ["/bin/ash", "-eo", "pipefail", "-c"]

Expand All @@ -26,25 +21,6 @@ RUN echo "@edge http://dl-cdn.alpinelinux.org/alpine/edge/main" >> /etc/apk/repo
echo "@edgecommunity http://dl-cdn.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories && \
echo "@testing http://dl-cdn.alpinelinux.org/alpine/edge/testing" >> /etc/apk/repositories

#WORKDIR /tmp
# Installing MSSQL-Tools
# hadolint ignore=DL3018,DL3019
#RUN apk add --no-cache wget gnupg --virtual .build-dependencies -- && \
# Adding custom MS repository for mssql-tools and msodbcsql
# wget https://download.microsoft.com/download/e/4/e/e4e67866-dffd-428c-aac7-8d28ddafb39b/msodbcsql17_${MSSQL_VERSION}_amd64.apk && \
# wget https://download.microsoft.com/download/e/4/e/e4e67866-dffd-428c-aac7-8d28ddafb39b/mssql-tools_${MSSQL_VERSION}_amd64.apk && \
# Verifying signature
# wget https://download.microsoft.com/download/e/4/e/e4e67866-dffd-428c-aac7-8d28ddafb39b/msodbcsql17_${MSSQL_VERSION}_amd64.sig && \
# wget https://download.microsoft.com/download/e/4/e/e4e67866-dffd-428c-aac7-8d28ddafb39b/mssql-tools_${MSSQL_VERSION}_amd64.sig && \
# Importing gpg key
# wget -O - https://packages.microsoft.com/keys/microsoft.asc | gpg --import - && \
# gpg --verify msodbcsql17_${MSSQL_VERSION}_amd64.sig msodbcsql17_${MSSQL_VERSION}_amd64.apk && \
# gpg --verify mssql-tools_${MSSQL_VERSION}_amd64.sig mssql-tools_${MSSQL_VERSION}_amd64.apk && \
# Installing packages
# echo y | apk add --allow-untrusted msodbcsql17_${MSSQL_VERSION}_amd64.apk mssql-tools_${MSSQL_VERSION}_amd64.apk && \
# Deleting packages
# apk del .build-dependencies && rm -f msodbcsql*.sig mssql-tools*.apk

COPY scripts/* /scripts/

# hadolint ignore=DL3017,DL3018
Expand Down Expand Up @@ -99,6 +75,4 @@ ENV PS1="\u@debugcontainer($(hostname)):\w\\$ " \
HOME="/workdir" \
TERM="xterm"

# Adding SQL Server tools to $PATH
# ENV PATH=$PATH:/opt/mssql-tools/bin:/bin/
CMD ["/scripts/idle.sh"]

0 comments on commit 29c36c7

Please sign in to comment.