Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli comments parsing #718

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

diegoreis42
Copy link
Contributor

#711

I followed the patterns that sqlite has, so everything after -- is treated as a comment. A bunch of spaces and a -- is treated as a comment also.

@PThorpe92
Copy link
Contributor

testing locally, I think we might have to handle cases like this too.
image

sqlite:
image

@diegoreis42
Copy link
Contributor Author

diegoreis42 commented Jan 16, 2025

testing locally, I think we might have to handle cases like this too. image

sqlite: image

I forgot to test this one, thanks! I'll work on that tonight. Do you think it needs an automated test?

EDIT: the fix was pretty trivial actually, just moved the check outside the self.input_buff.is_empty(), it should works fine now.

@penberg penberg closed this in 718ba17 Jan 17, 2025
@penberg penberg merged commit 718ba17 into tursodatabase:main Jan 17, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants