Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scaffolding for supporting wal checkpoint #694

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sonhmai
Copy link
Contributor

@sonhmai sonhmai commented Jan 15, 2025

add scaffolding for supporting wal checkpoint

  • add basic support for parsing pragma wal_checkpoint;
  • checkpoint opcode for instruction
  • cli test (not active yet)

basically to prepare for adding checkpoint support in the next PRs.

@sonhmai sonhmai changed the title add scaffolding for supporting wal checkpoint draft: add scaffolding for supporting wal checkpoint Jan 15, 2025
@sonhmai sonhmai marked this pull request as draft January 15, 2025 07:33
@sonhmai sonhmai force-pushed the feat/wal-checkpoint branch from e466847 to 807e0f4 Compare January 15, 2025 07:49
@sonhmai sonhmai marked this pull request as ready for review January 15, 2025 07:57
@sonhmai sonhmai marked this pull request as draft January 15, 2025 07:57
@sonhmai sonhmai mentioned this pull request Jan 15, 2025
7 tasks
@sonhmai
Copy link
Contributor Author

sonhmai commented Jan 15, 2025

The build on windows failed because rexpect is not supported in windows.
This one is only a dev-dependencies for integration testing the CLI.

Will need to look for a way to not building the cli tests in cli/tests in windows.
Although it does not work in windows, I still find that the integration tests of calling through cli written in Rust to be beneficial

  1. dev in rust, integration test in rust. no context switching to python or TCL. use cargo for all.
  2. advanced testing features (concurrency in tcl tests, etc.) in Rust instead of TCL.

@sonhmai sonhmai force-pushed the feat/wal-checkpoint branch from 3ebde0c to 465f14f Compare January 16, 2025 05:30
@sonhmai
Copy link
Contributor Author

sonhmai commented Jan 16, 2025

resolved the issue by 465f14f.

this PR for scaffold is ready for review. cc @penberg

@sonhmai sonhmai marked this pull request as ready for review January 16, 2025 05:44
@sonhmai sonhmai changed the title draft: add scaffolding for supporting wal checkpoint add scaffolding for supporting wal checkpoint Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant