Add clippy CI, fix or ignore warnings where appropriate #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @PThorpe92, can you please rebase this series. I think it has conflicts now due to a8e2f48 |
travenin
reviewed
Dec 29, 2024
| @@ -1748,6 +1748,7 @@ pub fn translate_expr( | |||
| Ok(target_register) | |||
| } | |||
| }, | |||
| #[allow(unreachable_patterns)] | |||
There was a problem hiding this comment.
I would remove _ => unreachable!() because having these are potential source of a bug when new variants are added to the enum.
There was a problem hiding this comment.
Yeah I believe I tried that when I implemented that feature. Unfortunately because that is the only variant, it will throw an error in this case when disabling the uuid feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no semantic changes in this PR, the clippy command came from @pereman2's suggestion in #542
There was more to fix than I previously thought. I originally set out to refactor out some of the logic in
vdbe::step, but with some actual semantic changes. That file:vdbe/mod.rsis so full that it required moving theInsnenum to another file, so I figured I would just put some non-semantic changes all together so it's easier to review and get that done first... and figured I'd fix some clippy warnings while I was at it. Also adjusted the actions tocheckout/@v3.The project is obviously so early that there are going to be a decent amount of things like unused fields or methods, which is why I was originally not really pro clippy.. but seeing how many genuinely good improvements it recommended, I think it's probably the right way to go.