-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make iterate() lazily evaluated on wasm #527
base: main
Are you sure you want to change the base?
Conversation
@diegoreis42 Looks great! I am guessing some auto-formatted turned the diff on the test file into something that's pretty unreadable. Can you please change back to 4 space indent to make that change readable? |
@diegoreis42 FYI, Edit: Never mind , just checked the |
Yeah sure, sorry about that. |
Hey, I thought that CI test suit would run wasm tests but, apparently, it doesn't. Some changes are needed to conform with previous tests, I'm working on this. In order to test if the rows are lazily loaded, I wrote a SQL trigger, but it has not been implemented yet by Limbo, so it throws an error. Any inputs in how to test if the rows are lazily loaded? Btw, perhaps it would be nice to include wasm testing on CI, afaik only wasm build is executed, I can try do this in another PR. |
@penberg in the iterator, when a row is busy it returns undefined, it's fine or other behavior is required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase, it will be unreviewable if I cannot find the changes.
Done. |
#514
Introduces a new feature for lazy evaluation in the
Statement.raw().iterate()
method and includes related changes in both the test and implementation files. The most important changes include adding a test case for lazy evaluation, creating aRowIterator
struct, and modifying theiterate
method to use this new struct.Everything seems to works fine, but suggestions on code improvement and test use cases are welcoming.