Run clippy in ci
#542
Comments
|
Running clippy in CI for every PR would be very good idea to keep codebase in better shape. However, there are quite a lot of issues in the main branch currently. Majority of them should be fixed first. However, I am interested in working on this issue. |
|
I've been avoiding this as much as possible because I hate some things from clippy, but overall it is a good direction. I would suggest using this command as the entrypoint |
|
Good point. It's not necessary to keep clippy perfectly happy. Your suggested command looks good place to start. 👍 |
pereman2
added a commit
that referenced
this issue
Dec 29, 2024
…Preston Thorpe There is no semantic changes in this PR, the clippy command came from @pereman2's suggestion in #542 There was more to fix than I previously thought. I originally set out to refactor out some of the logic in `vdbe::step`, but with some actual semantic changes. That file: `vdbe/mod.rs` is so full that it required moving the `Insn` enum to another file, so I figured I would just put some non-semantic changes all together so it's easier to review and get that done first... and figured I'd fix some clippy warnings while I was at it. Also adjusted the actions to `checkout/@v3`. The project is obviously so early that there are going to be a decent amount of things like unused fields or methods, which is why I was originally not really pro clippy.. but seeing how many genuinely good improvements it recommended, I think it's probably the right way to go. Closes #563
|
We run Clippy now as part of the CI as of f6cd707. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The contribution guide suggests running
clippy. There are several pull requests that use thecargo clippy fix. But at the same time, I did not find acijob that would checkclippy, which looks strange.The text was updated successfully, but these errors were encountered: