expose the libsql_close_hook to loadable extensions #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libsql_close_hook was added here in tursodatabase#219 but it is not available to loadable extensions. Following the same pattern was was done for `wal_methods_unregister` (tursodatabase@47e59b7) to expose this to loadable extensions. - Will be used in tursodatabase#434 to do cleanup of cr-sqlite
tantaman
force-pushed
the
close_hook_loadable
branch
from
3ceb251 to
23037f1
Compare
|
@psarna i think this is for you |
psarna
approved these changes
Oct 5, 2023
| @@ -370,6 +370,7 @@ struct libsql_api_routines { | |||
| struct libsql_wal_methods *(*wal_methods_find)(const char *); | |||
| int (*wal_methods_register)(struct libsql_wal_methods*); | |||
| int (*wal_methods_unregister)(struct libsql_wal_methods*); | |||
| void *(*close_hook)(sqlite3*, void(*)(void*,sqlite3*), void *pArg); | |||
There was a problem hiding this comment.
that one will be available in libSQL 0.2.3 - let's add a comment, following SQLite style above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsql_close_hookwas added here (#219) but it is not available to loadable extensions.Following the same pattern was was done for
wal_methods_unregister(47e59b7) to expose this to loadable extensions.