-
Notifications
You must be signed in to change notification settings - Fork 114
Add aws_sesv2_suppressed_destination table #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_sesv2_suppressed_destination table #2631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Steampipe table aws_ses_suppressed_destination that enables querying AWS SES suppressed email destinations through the SES v2 API. This provides visibility into email addresses that have been automatically suppressed due to bounces or complaints.
- Implements a new table to list email addresses on the SES account-level suppression list
- Adds support for the AWS SES v2 service client
- Updates AWS SDK dependencies to support the required SES v2 functionality
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates AWS SDK dependencies and adds sesv2 service support |
| aws/table_aws_ses_suppressed_destination.go | Implements the new table with list and hydration functions |
| aws/service.go | Adds SESV2Client function for service connectivity |
| aws/plugin.go | Registers the new table in the plugin |
| docs/tables/aws_ses_suppressed_destination.md | Provides comprehensive documentation with usage examples |
| aws-test/tests/aws_ses_suppressed_destination/* | Test configuration files for the new table |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ParthaI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jramosf, I’ve added a few review comments — please take a look when you get a chance.
Additionally:
- We are updating the AWS SDK V2 package from
v1.36.6tov1.38.3. Please ensure there are no breaking changes. - Kindly remove the integration test, as Terraform doesn’t support it yet. Otherwise, we could consider using AWS CLI commands via Terraform to create the resources.
Please don’t hesitate to let us know if anything is unclear.
Thanks!
49bc063 to
c17ae3b
Compare
|
Hello @jramosf, apologies for the delay in this process.
Have you had a chance to review or run regression tests on the other tables with the updated SDK package? |
Hello, So far I didn't see any test failures and I have been using this build to query other tables in real AWS accounts (apart from the tests). The SDK is also updating a minor so from semantic versioning perspective there should not be any breaking changes. This is available in https://pkg.go.dev/github.com/aws/aws-sdk-go-v2?tab=versions, where we can see that the versions are not that far apart anyways: v1.36.6 Jul 19, 2025 No breaking changes mentioned between those dates in https://github.com/aws/aws-sdk-go-v2/releases |
|
Thank you so much @jramosf, for the confirmation. I will review the PR again and move forward. |
ParthaI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jramosf, I’ve left a few review comments. Please take a look when you get a chance, and feel free to reach out to us if you have any questions. Thanks!
01371d4 to
cd7de9e
Compare
cd7de9e to
d36e3b8
Compare
|
Hello @ParthaI , sorry this pending Pull Request slipped. I have addressed your comments and rebased the branch. I have gone with the quals approach, since as you also saw the API doesn't support complex operators. Thanks for reviewing! |
|
Hi @jramosf could you please address the merge conflicts in this PR? Thank you once again for adding the new table 👍 !! |
d36e3b8 to
23135dc
Compare
Rebased the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cfcf75f to
f441585
Compare
|
@misraved @ParthaI the Copilot AI is making up stuff and wasting my time: I have done one of the suggestions and the code now compiles correctly and I have tested also works as expected. I have allowed edits by maintainers so you can add further changes if appropriate. This is my last push to this Pull Request. Thanks, |
|
That makes sense @jramosf 👍 !! Apologies for the incorrect reviews from Copilot AI. I will prioritise getting the review and release done for this table. Thanks once again for raising this PR. |
…s-suppressed-destination
ef59148
into
turbot:add-aws-sesv2-suppressed-destination-table
This adds a new table in line with https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_ListSuppressedDestinations.html
Integration test logs
Logs
Example query results
Results