Skip to content

Conversation

@jramosf
Copy link
Contributor

@jramosf jramosf commented Sep 4, 2025

This adds a new table in line with https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_ListSuppressedDestinations.html

Integration test logs

Logs
  N/A, Terraform resource does not exist in AWS provider

Example query results

Results
select
  email_address,
  reason,
  last_update_time,
  region
from
  aws_ses_suppressed_destination
where
  region = 'us-west-2'
limit 5;
+-------------------------------------------+--------+---------------------------+-----------+
| email_address                             | reason | last_update_time          | region    |
+-------------------------------------------+--------+---------------------------+-----------+
| [email protected]                   | BOUNCE | 2024-08-22T11:31:32+02:00 | us-west-2 |
| [email protected]                         | BOUNCE | 2024-05-15T20:25:34+02:00 | us-west-2 |
| [email protected]              | BOUNCE | 2024-02-02T18:32:29+01:00 | us-west-2 |
| [email protected]                         | BOUNCE | 2024-04-01T10:28:22+02:00 | us-west-2 |
| [email protected]                        | BOUNCE | 2024-01-24T18:15:21+01:00 | us-west-2 |
+-------------------------------------------+--------+---------------------------+-----------+

@ParthaI ParthaI requested a review from Copilot September 4, 2025 14:19
@ParthaI ParthaI added the community-contribution Pull requests for plugins contributed by the community label Sep 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Steampipe table aws_ses_suppressed_destination that enables querying AWS SES suppressed email destinations through the SES v2 API. This provides visibility into email addresses that have been automatically suppressed due to bounces or complaints.

  • Implements a new table to list email addresses on the SES account-level suppression list
  • Adds support for the AWS SES v2 service client
  • Updates AWS SDK dependencies to support the required SES v2 functionality

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updates AWS SDK dependencies and adds sesv2 service support
aws/table_aws_ses_suppressed_destination.go Implements the new table with list and hydration functions
aws/service.go Adds SESV2Client function for service connectivity
aws/plugin.go Registers the new table in the plugin
docs/tables/aws_ses_suppressed_destination.md Provides comprehensive documentation with usage examples
aws-test/tests/aws_ses_suppressed_destination/* Test configuration files for the new table

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@ParthaI ParthaI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jramosf, I’ve added a few review comments — please take a look when you get a chance.

Additionally:

  • We are updating the AWS SDK V2 package from v1.36.6 to v1.38.3. Please ensure there are no breaking changes.
  • Kindly remove the integration test, as Terraform doesn’t support it yet. Otherwise, we could consider using AWS CLI commands via Terraform to create the resources.

Please don’t hesitate to let us know if anything is unclear.

Thanks!

@ParthaI ParthaI added aws AWS plugin issues steampipe Steampipe plugin issues labels Sep 4, 2025
@jramosf jramosf force-pushed the add-ses-suppressed-destination branch from 49bc063 to c17ae3b Compare September 8, 2025 13:20
@jramosf jramosf requested a review from ParthaI September 9, 2025 09:22
@ParthaI
Copy link
Contributor

ParthaI commented Sep 17, 2025

Hello @jramosf, apologies for the delay in this process.

We are updating the AWS SDK V2 package from v1.36.6 to v1.38.3. Please ensure there are no breaking changes.

Have you had a chance to review or run regression tests on the other tables with the updated SDK package?

@jramosf
Copy link
Contributor Author

jramosf commented Sep 17, 2025

Hello @jramosf, apologies for the delay in this process.

We are updating the AWS SDK V2 package from v1.36.6 to v1.38.3. Please ensure there are no breaking changes.

Have you had a chance to review or run regression tests on the other tables with the updated SDK package?

Hello,

So far I didn't see any test failures and I have been using this build to query other tables in real AWS accounts (apart from the tests).

The SDK is also updating a minor so from semantic versioning perspective there should not be any breaking changes. This is available in https://pkg.go.dev/github.com/aws/aws-sdk-go-v2?tab=versions, where we can see that the versions are not that far apart anyways:

v1.36.6 Jul 19, 2025
v1.38.3 Aug 29, 2025

No breaking changes mentioned between those dates in https://github.com/aws/aws-sdk-go-v2/releases

@ParthaI
Copy link
Contributor

ParthaI commented Sep 17, 2025

Thank you so much @jramosf, for the confirmation. I will review the PR again and move forward.

Copy link
Contributor

@ParthaI ParthaI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jramosf, I’ve left a few review comments. Please take a look when you get a chance, and feel free to reach out to us if you have any questions. Thanks!

@jramosf jramosf force-pushed the add-ses-suppressed-destination branch 2 times, most recently from 01371d4 to cd7de9e Compare October 2, 2025 09:21
@jramosf jramosf requested a review from ParthaI October 2, 2025 09:21
@jramosf jramosf force-pushed the add-ses-suppressed-destination branch from cd7de9e to d36e3b8 Compare October 2, 2025 09:22
@jramosf
Copy link
Contributor Author

jramosf commented Oct 2, 2025

Hello @ParthaI , sorry this pending Pull Request slipped. I have addressed your comments and rebased the branch.

I have gone with the quals approach, since as you also saw the API doesn't support complex operators.

Thanks for reviewing!

@misraved
Copy link
Contributor

misraved commented Oct 9, 2025

Hi @jramosf could you please address the merge conflicts in this PR?

Thank you once again for adding the new table 👍 !!

@jramosf jramosf force-pushed the add-ses-suppressed-destination branch from d36e3b8 to 23135dc Compare October 9, 2025 06:45
@jramosf
Copy link
Contributor Author

jramosf commented Oct 9, 2025

Hi @jramosf could you please address the merge conflicts in this PR?

Thank you once again for adding the new table 👍 !!

Rebased the PR

@misraved misraved self-requested a review October 9, 2025 14:03
@misraved misraved requested a review from Copilot October 21, 2025 20:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jramosf jramosf force-pushed the add-ses-suppressed-destination branch from cfcf75f to f441585 Compare October 22, 2025 06:17
@jramosf
Copy link
Contributor Author

jramosf commented Oct 22, 2025

@misraved @ParthaI the Copilot AI is making up stuff and wasting my time:

aws/table_aws_sesv2_suppressed_destination.go:167:5: d.WaitForHydrateCallRateLimit undefined (type *"github.com/turbot/steampipe-plugin-sdk/v5/plugin".QueryData has no field or method WaitForHydrateCallRateLimit)

I have done one of the suggestions and the code now compiles correctly and I have tested also works as expected. I have allowed edits by maintainers so you can add further changes if appropriate. This is my last push to this Pull Request.

Thanks,

@misraved
Copy link
Contributor

That makes sense @jramosf 👍 !!

Apologies for the incorrect reviews from Copilot AI. I will prioritise getting the review and release done for this table.

Thanks once again for raising this PR.

@misraved misraved changed the title Add table_aws_ses_suppressed_destination Add aws_sesv2_suppressed_destination table Oct 29, 2025
@misraved misraved changed the base branch from main to add-aws-sesv2-suppressed-destination-table October 29, 2025 14:05
@misraved misraved merged commit ef59148 into turbot:add-aws-sesv2-suppressed-destination-table Oct 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws AWS plugin issues community-contribution Pull requests for plugins contributed by the community steampipe Steampipe plugin issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants