Skip to content

Commit

Permalink
docs: Add source tag best practices to the metric schema docs (influx…
Browse files Browse the repository at this point in the history
  • Loading branch information
reimda authored Aug 3, 2022
1 parent 478290c commit f001c99
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions docs/developers/REVIEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,17 @@ should be made to switch between these two styles but if given the option it
is preferred to use the non-reseting variant. This style is more resilient in
the face of downtime and does not contain a fixed time element.

### Source tag

When metrics are gathered from another host, the metric schema should have a tag
named "source" that contains the other host's name. See [this feature
request](https://github.com/influxdata/telegraf/issues/4413) for details.

The metric schema doesn't need to have a tag for the host running
telegraf. Telegraf agent code can add a tag named "host" and by default
containing the hostname reported by the kernel. This can be configured through
the "hostname" and "omit_hostname" agent settings.

## Go Best Practices

In general code should follow best practice describe in [Code Review
Expand Down

0 comments on commit f001c99

Please sign in to comment.