Skip to content

feat(PBXFileReference): add expectedSignature property #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

TamarMilchtaich
Copy link
Contributor

Short description 📝

Adds support for XCFrameworks expected signature, as explained in this Apple documentation:
Verifying the origin of your XCFrameworks

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 17, 2025
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but let's wait for the tuist counterpart PR to get closer to being mergeable.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 17, 2025
@TamarMilchtaich TamarMilchtaich force-pushed the xcframeworks-expected-signature branch from a11e0ea to 43739d3 Compare April 10, 2025 14:44
@TamarMilchtaich
Copy link
Contributor Author

(Same commit, rebased)

@fortmarek
Copy link
Member

Let's merge this once the CI passes since the tuist/tuist counterpart PR is now almost in a mergeable state.

@TamarMilchtaich TamarMilchtaich force-pushed the xcframeworks-expected-signature branch from 43739d3 to 5d34fab Compare April 29, 2025 18:54
@pepicrft pepicrft merged commit 564a9d1 into tuist:main Apr 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants