Skip to content

Commit

Permalink
fix(gebura): update SyncApps
Browse files Browse the repository at this point in the history
  • Loading branch information
MuZhou233 committed Jan 15, 2024
1 parent bdc3d1c commit 45a8a46
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 6 deletions.
9 changes: 7 additions & 2 deletions proto/librarian/sephirah/v1/gebura.proto
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,15 @@ message ListAppsResponse {
}

message SyncAppsRequest {
librarian.v1.AppID app_id = 1;
repeated librarian.v1.AppID app_ids = 1;
// if false, server will return immediately.
// if true, server will return data after sync finished.
optional bool wait_data = 2;
}

message SyncAppsResponse {}
message SyncAppsResponse {
repeated librarian.v1.App apps = 1;
}

message MergeAppsRequest {
// `internal` must be true
Expand Down
6 changes: 5 additions & 1 deletion proto/librarian/sephirah/v1/sephirah.proto
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,13 @@ service LibrarianSephirahService {
// `Gebura` `Admin` Asynchronous update apps.
// Request on INTERNAL app applies to all bound external apps.
// Create an INTERNAL app when requested external app does not exist
// Server should implement a sync rate limit to prevent abuse,
// when rate limit reached, return without real sync.
rpc SyncApps(SyncAppsRequest) returns (SyncAppsResponse);
// `Gebura` `Admin` Asynchronously update apps associated with an account.
// Create an INTERNAL app when associated external app does not exist
// Create an INTERNAL app when associated external app does not exist.
// Server should implement a sync rate limit to prevent abuse,
// when rate limit reached, return without real sync.
rpc SyncAccountApps(SyncAccountAppsRequest) returns (SyncAccountAppsResponse);
// `Gebura` `Admin` Merge two apps
rpc MergeApps(MergeAppsRequest) returns (MergeAppsResponse);
Expand Down
9 changes: 6 additions & 3 deletions proto/librarian/v1/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,12 @@ message App {
AppType type = 8;
string short_description = 9;
string icon_image_url = 10;
string hero_image_url = 11;
repeated string tags = 12;
repeated string alt_names = 13;
// must be horizontal, usually 16:9
string background_image_url = 11;
// must be vertical, usually 4:3
string cover_image_url = 12;
repeated string tags = 13;
repeated string alt_names = 14;
}

// Mixed info of bound apps
Expand Down

0 comments on commit 45a8a46

Please sign in to comment.