Skip to content

ConfigParser only stores config data #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

bakhtos
Copy link
Contributor

@bakhtos bakhtos commented Oct 31, 2024

This PR simplifies the responsibilities of the ConfigParser object used internally:

  • Communications_tech_list is not given in config, it is now part of technology_switch code
    • Similarly, there is now container_tech_list which bundles together maven, gradle and docker-compose used to detect microservices, allowing it to be extended in the future with more technologies
  • What used to be temp.tmp.tmp_config is now core.config.code2dfd_config
    • Defaults are initialized in the same file
  • commit field is now part of Repository group, not Analysis settings; the latter IMO should be left for code2DFD-internal things
  • DFD is not stored as a string in ConfigParser, it is now a dict of microservices, information_flows and external_components as an intermediate step before migrating to proper objects
    • All detector functions (at least the "entry points") how accept only the dfd object and get the necessary parts internally when necessary, in the end they set the updated datastructures
    • technology_switch is not used as a getter for services/information_flows, the functions are renamed to set_microservices and set_information_flows and are only called once, in the appropriate place in DFD_extraction, all other functions get the data from the dfd dictionary directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant