Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes to geertsma branch #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Apply changes to geertsma branch #23

wants to merge 1 commit into from

Conversation

gabrielserrao
Copy link
Collaborator

Implemented geertsma, both for disc and nucleous of strain

@prisae
Copy link
Member

prisae commented Mar 12, 2025

Thanks Gabriel, this is great! I will have a look over the weekend or next week.

Currently all tests fail, primarily due to flak8 (code style). I can sort that out, but if you want, you can also tackle it. Locally, just run make flake8, and it will lint your code and give you feedback.

You can also run locally make pytest, to see if the actual tests pass.

@prisae
Copy link
Member

prisae commented Mar 12, 2025

Also, any code added to dageo (not to the examples) will have to be covered by tests. We can work on that together.

@prisae prisae mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants