ci: gate publish behind the release environment; run tests in CI - #17
Merged
Conversation
Merging a version bump auto-tags via the tag job, and the tag previously fired release.yml straight through to npm, GHCR, and a GitHub Release with no human in the loop. Point both release jobs at the `release` environment, which has required reviewers, so a tagged build stages and waits for approval instead of shipping itself. One approval unblocks both jobs in the run. Also run type-check and the test suite in CI. src/util/semaphore.test.ts has never executed on any push or PR because the build job only ran `npm run build`. Both pass on main today, so this adds a gate without changing any behavior.
Enabling `npm test` in CI surfaced a latent problem: the script passes a glob to `node --test`, and glob support in the test runner only landed in Node 21. The build job ran Node 20, which treated the pattern as a literal path and failed with "Could not find .../src/**/*.test.ts". release.yml already pins Node 22. `engines` stays >=18 — installing the package runs `prepare` (tsc build), never the test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for a second contributor working across the MCP repos.
What this changes
Publish is now gated. Today, merging a PR that bumps
package.jsonversion makes thetagjob inci.ymlpush av*tag, which firesrelease.yml, which publishes to npm (with provenance), pushes GHCR images, and cuts a GitHub Release — with no human approval anywhere in the chain.Both jobs in
release.ymlnow target thereleaseenvironment, which is configured with required reviewers. A tagged build now stages and waits for approval. One approval unblocks both jobs in the run.CI now runs tests. The
buildjob only rannpm run build, sosrc/util/semaphore.test.tshas never executed on any push or PR. Addednpm run type-checkandnpm test, matching whatmediawiki-mcpCI already does.Verification
Both commands pass on
mainas of this branch:So this adds a gate without changing behavior or requiring any fix.
Not changed
Merging and tagging are still unrestricted — only the publish waits. PR preview images (
docker-preview) are unaffected.