改行問題に対応するためJSDOMから変更 #147
Merged
改行問題に対応するためJSDOMから変更 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is linked to issue #144 |
|
### ウォークスルー
この変更では、HTMLコンテンツの解析に使用するパーサーを`jsdom`から`htmlparser2`に変更し、特定の属性を持つ要素のテキスト内容を収集する機能が強化されました。また、システムメッセージ生成関数の出力フォーマットに関する指示が追加され、改行文字を保持するようになりました。
### 変更点
| ファイル | 要約 |
| --- | --- |
| web/app/feature/translate/utils/extractNumberedElements.ts | `extractNumberedElements`関数が`jsdom`から`htmlparser2`に変更され、`data-number`属性を持つ要素を検出し、そのテキスト内容を収集するようになりました。 |
| web/app/feature/translate/utils/generateGeminiMessage.ts | `generateSystemMessage`関数の出力フォーマットに関する指示が追加され、改行文字を保持するようになりました。 |Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
Closed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (2)
- web/app/feature/translate/utils/extractNumberedElements.ts (1)
- web/app/feature/translate/utils/generateGeminiMessage.ts (2)
Review comments generated (12)
- Review: 1
- LGTM: 11
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Comment on lines
+24
to
+28
| ontext(text) { | ||
| if (inNumberedElement) { | ||
| currentText.push(text.trim()); | ||
| } | ||
| }, |
There was a problem hiding this comment.
26行目のtext.trim()は、テキスト内のすべての空白を削除してしまう可能性があります。改行タグ（
）の処理と矛盾する可能性があるため、ここではtrimを使用しない方が良いでしょう。
- currentText.push(text.trim());
+ currentText.push(text);
ttizze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144
Summary by CodeRabbit