feat: Add number parameter to getOrCreateSourceTextId function (#8)

ttizze · Jul 14, 2024 · f9c3e95 · f9c3e95
1 parent 3889368
commit f9c3e95
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 4 deletions.
diff --git a/web/app/routes/_index/utils/translation.ts b/web/app/routes/_index/utils/translation.ts
@@ -108,7 +108,7 @@ async function getOrCreateTranslations(
 	const untranslatedElements: { number: number; text: string }[] = [];
 	const sourceTextsId = await Promise.all(
 		elements.map((element) =>
-			getOrCreateSourceTextId(element.text, pageId, pageVersionId),
+			getOrCreateSourceTextId(element.text, element.number, pageId, pageVersionId),
 		),
 	);
 
@@ -188,6 +188,7 @@ async function translateUntranslatedElements(
 
 			const sourceTextId = await getOrCreateSourceTextId(
 				sourceText,
+				translation.number,
 				pageId,
 				pageVersionId,
 			);

diff --git a/web/app/utils/sourceTextService.ts b/web/app/utils/sourceTextService.ts
@@ -3,6 +3,7 @@ import { prisma } from "./prisma";
 
 export async function getOrCreateSourceTextId(
 	text: string,
+	number: number,
 	pageId: number,
 	pageVersionId: number,
 ): Promise<number> {
@@ -14,14 +15,16 @@ export async function getOrCreateSourceTextId(
 	try {
 		const sourceText = await prisma.sourceText.upsert({
 			where: {
-				textHash_pageId: {
+				textHash_pageVersionId_number: {
 					textHash,
-					pageId,
+					pageVersionId,
+					number,
 				},
 			},
 			update: {},
 			create: {
 				text,
+				number,
 				textHash,
 				pageId,
 				pageVersionId,

diff --git a/web/prisma/migrations/20240714130117_/migration.sql b/web/prisma/migrations/20240714130117_/migration.sql
@@ -0,0 +1,15 @@
+/*
+  Warnings:
+
+  - A unique constraint covering the columns `[text_hash,page_version_id,number]` on the table `source_texts` will be added. If there are existing duplicate values, this will fail.
+  - Added the required column `number` to the `source_texts` table without a default value. This is not possible if the table is not empty.
+
+*/
+-- DropIndex
+DROP INDEX "source_texts_text_hash_page_id_key";
+
+-- AlterTable
+ALTER TABLE "source_texts" ADD COLUMN     "number" INTEGER NOT NULL;
+
+-- CreateIndex
+CREATE UNIQUE INDEX "source_texts_text_hash_page_version_id_number_key" ON "source_texts"("text_hash", "page_version_id", "number");
diff --git a/web/prisma/schema.prisma b/web/prisma/schema.prisma
@@ -66,14 +66,15 @@ model PageVersion {
 model SourceText {
   id             Int             @id @default(autoincrement())
   text           String
+  number         Int
   textHash       Bytes           @map("text_hash")
   pageId         Int             @map("page_id")
   pageVersionId  Int             @map("page_version_id")
   page           Page            @relation(fields: [pageId], references: [id])
   pageVersion    PageVersion     @relation(fields: [pageVersionId], references: [id])
   translateTexts TranslateText[]
 
-  @@unique([textHash, pageId])
+  @@unique([textHash, pageVersionId, number])
   @@index([textHash])
   @@map("source_texts")
 }