Skip to content

Add support for ruby 3.1.0, compose for coverage#1

Open
dwillett wants to merge 1 commit intotsutsu:fork-masterfrom
dwillett:features/ruby-3-1-0
Open

Add support for ruby 3.1.0, compose for coverage#1
dwillett wants to merge 1 commit intotsutsu:fork-masterfrom
dwillett:features/ruby-3-1-0

Conversation

@dwillett
Copy link
Copy Markdown

@dwillett dwillett commented Jan 27, 2022

Adding a similar docker-compose ruby version coverage setup as k8s-ruby, bringing in compatibility for ruby 3.1.0 and Psych's changed method signatures.

This update is prerequisite for 3.1 support in k8s-ruby: k8s-ruby/k8s-ruby#29

@dwillett
Copy link
Copy Markdown
Author

Not sure about updating the travis CI coverage or if that's still active, feel free to edit or advise any update there

@matti
Copy link
Copy Markdown

matti commented Feb 2, 2022

no idea about travis - thanks for this, I'll merge this shortly. didnt get notification from github, that's why it has taken some time :(

@matti
Copy link
Copy Markdown

matti commented Feb 2, 2022

aaah haha - this is not k8s-ruby repo :D - sorry

@dwillett
Copy link
Copy Markdown
Author

dwillett commented Feb 2, 2022

Ha okay yeah, that was my original concern. Is there anyone available to review/merge/publish from this repo?

@matti
Copy link
Copy Markdown

matti commented Feb 2, 2022

@dwillett what about just forking and using the fork?

@dwillett
Copy link
Copy Markdown
Author

dwillett commented Feb 2, 2022

Yeah it makes sense to me to fork it into k8s-ruby org and maybe just publish under another new name going forward?

@matti
Copy link
Copy Markdown

matti commented Feb 3, 2022

yes!

@dwillett
Copy link
Copy Markdown
Author

dwillett commented Feb 3, 2022

Do you have full access to fork into k8s-ruby org?

@matti
Copy link
Copy Markdown

matti commented Feb 3, 2022

@dwillett yes, and you should do. Anyway I just hit fork.

@dwillett
Copy link
Copy Markdown
Author

dwillett commented Feb 3, 2022

I am only marked as an outside collaborator on the one repository, so I don't have much access right now

@matti
Copy link
Copy Markdown

matti commented Feb 3, 2022

tried to give full admin rights

@clintoncwolfe
Copy link
Copy Markdown

Hey, just chiming in here, we'd like to see Ruby 3.1 support in k8s-ruby and getting this PR merged and an updated gem published is need for that. Could that happen? If not, hate to do it, but we're motivated to (re-)fork and rename again, as suggested above.

Looks like as of now it has been forked into https://github.com/k8s-ruby/yaml-safe_load_stream2 but no other work was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants