-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): replace dependency rollup-plugin-terser with @rollup/plugin-terser ^0.1.0 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5eda6a1
to
088fad9
Compare
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe project has transitioned from using Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
088fad9
to
71a93ec
Compare
71a93ec
to
f605875
Compare
f605875
to
db117f8
Compare
db117f8
to
5d69a1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- package.json (1 hunks)
Additional comments not posted (2)
package.json (2)
21-21
: Verify version number for@rollup/plugin-terser
.The version
^0.1.0
seems unusually low for a replacement ofrollup-plugin-terser
which was at^7.0.0
. This could be a major version downgrade or a reset in version numbering due to the rebranding under a scoped package. Please confirm that this version is correct and that it contains all necessary features and compatibility with the current Rollup version used in the project (^3.0.0
).
21-21
: Ensure compatibility with existing Rollup configuration and plugins.Given the significant version change, it's crucial to ensure that
@rollup/plugin-terser
integrates well with the existing Rollup version (^3.0.0
) and other plugins likerollup-plugin-svelte
(^7.0.0
). Review the plugin's documentation for any breaking changes or new configurations required.
5d69a1e
to
fa211ee
Compare
fa211ee
to
8f4582d
Compare
8f4582d
to
009da7f
Compare
009da7f
to
16f2bf3
Compare
16f2bf3
to
a557006
Compare
a557006
to
ca03e68
Compare
ca03e68
to
b14e9f1
Compare
b14e9f1
to
8711c01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
package.json
(1 hunks)
@@ -18,7 +18,7 @@ | |||
"rollup": "^3.0.0", | |||
"rollup-plugin-livereload": "^2.0.0", | |||
"rollup-plugin-svelte": "^7.0.0", | |||
"rollup-plugin-terser": "^7.0.0", | |||
"@rollup/plugin-terser": "^0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Dependency Update: Verify Compatibility of New Terser Plugin
The dependency update to "@rollup/plugin-terser": "^0.1.0"
replaces the older "rollup-plugin-terser": "^7.0.0"
. Please ensure that the Rollup configuration is updated accordingly, as the API for the new plugin might differ from the old one. It is recommended to verify that all build configurations and any custom terser options are still valid with the new dependency.
Please run the above script to verify that:
- All references to
"rollup-plugin-terser"
have been removed. - The new dependency
"@rollup/plugin-terser"
is in use in both the package configuration and any relevant Rollup config files.
Once you confirm these checks, we can safely conclude that the updated dependency is implemented correctly.
🏁 Script executed:
#!/bin/bash
echo "Verifying dependency updates in the codebase..."
echo -e "\nSearching for references to the old dependency 'rollup-plugin-terser':"
rg "rollup-plugin-terser" .
echo -e "\nSearching for references to the new dependency '@rollup/plugin-terser':"
rg "@rollup/plugin-terser" .
Length of output: 1035
Action Required: Update Rollup Configuration for New Terser Plugin
The new dependency "@rollup/plugin-terser": "^0.1.0"
has been added to package.json
and is correctly reflected in yarn.lock
. However, our search revealed that references to the old dependency (rollup-plugin-terser
) still exist in the codebase:
- In rollup.config.js, the code still imports terser as follows:
import { terser } from 'rollup-plugin-terser';
- In scripts/setupTypeScript.js, there is a reference that manipulates the old dependency string.
Next Steps:
- Update rollup.config.js to import terser from
"@rollup/plugin-terser"
, adapting any API changes if necessary. - Revise scripts/setupTypeScript.js to remove or update references to
"rollup-plugin-terser"
in favor of the new plugin.
Please ensure that all build configurations and custom terser options are compatible with the new dependency.
8711c01
to
71bdd3f
Compare
71bdd3f
to
698a088
Compare
…gin-terser ^0.1.0
698a088
to
2a1874d
Compare
This PR contains the following updates:
^7.0.0
->^0.1.0
This is a special PR that replaces
rollup-plugin-terser
with the community suggested minimal stable replacement version.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit