refactor: add physical endpoint label plumbing#48
Open
okhomenko wants to merge 2 commits intotsowell:mainfrom
Open
refactor: add physical endpoint label plumbing#48okhomenko wants to merge 2 commits intotsowell:mainfrom
okhomenko wants to merge 2 commits intotsowell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds preparatory plumbing for physical endpoint labels without changing the default UI behavior yet.
It establishes a shared PipeWire-state layer for endpoint/profile label lookup and exposes a computed naming key that follow-up PRs can start using for endpoint defaults and Configuration titles.
What changed
SPA_PARAM_ROUTE_infoentries onEnumRoutecomputed:namespace to the naming/matching systemcomputed:physical.endpoint.labelview.rsto use shared state helpers for route/profile/device matching instead of owning that logic locallyREADME.mdandwiremix.tomlBehavior
computed:physical.endpoint.labelresolves in this order:node.nickdevice.product.namewhen it maps unambiguouslyThis PR does not change the default endpoint naming templates or Configuration titles yet.
Follow-ups
{computed:physical.endpoint.label}Testing
I added unit coverage for route-info parsing, computed-key rendering, computed-key override matching, and ambiguous profile-label cases.