This repository was archived by the owner on Nov 11, 2021. It is now read-only.
Add guessing game #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drocha87
reviewed
Sep 28, 2021
examples/guessing_game.porth
Outdated
| mem 10 + 1 .64 | ||
|
|
||
| //read stdin | ||
| 255 mem 20 + stdout SYS_read syscall3 |
Contributor
There was a problem hiding this comment.
Why are you reading from stdout? you should read from stdin and write to stdout right?
Author
There was a problem hiding this comment.
Yes, thanks. Didn't notice it, because it works anyway lol.
Will fix that
Contributor
There was a problem hiding this comment.
No problem, this works because you're not redirecting the stdout/stderr/stdin. Try something like this ./examples/guessing_game 2>&1 | tee -a some_file and you program will segfault.
Author
There was a problem hiding this comment.
Makes sense. I also wrote stdin in place of stdout in some other places :|
All fixed now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've made a guessing game in porth.
It's compile only, because it uses read syscall to read stdin and uses argv pointer to get pseudo random number.
I might try to implement the read syscall in simulation later.
Not sure if I should mark this as draft.