Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ティザーサイト用のカラーパレットを追加 #47

Merged
merged 4 commits into from
Jan 26, 2025

Conversation

kp047i
Copy link
Contributor

@kp047i kp047i commented Jan 18, 2025

やったこと

キャプチャ

localhost_3000_ (2)

相談したいこと

  • 最初はtailwindのクラスにティザー用のprefixをつけようと思ったが、コードないに置かれているclass名を置換するのが難しそうだったので、そのまま戻したが問題ないか
  • ティザーサイトにフッターは必要か

@masayaO masayaO self-requested a review January 18, 2025 12:30
Copy link
Collaborator

@masayaO masayaO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装ありがとうございます!
フッターは表示しなくて大丈夫です

@kp047i
Copy link
Contributor Author

kp047i commented Jan 22, 2025

@masayaO
修正しました!
fix: ティザーサイトからfooterを削除

Copy link
Collaborator

@masayaO masayaO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masayaO masayaO merged commit 3f62c47 into develop Jan 26, 2025
1 check passed
@masayaO masayaO deleted the feature/#45 branch January 26, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants