Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying a fix for #59 . In other words, this pull request enables the usage of
connection.query
and similar methods with all possible mysql function signatures. This makes it possible to pass an options object toconnection.query
. Previously this was not possible because the function signature was fixed to only one case.Implementation details:
createQuery
. This function takes all possible signatures and produces the corresponding values by handling all cases as can be seen here. Moreover, the function already returns the input if it is already an instance ofQuery
(already executedcreateQuery()
)instanceof Query
check, I had to turn the mysql dependency to a dev dependency and to a peer dependency. In this way we make sure that the instance of theQuery
is the same instance that the consumers of this package are going to use. Especially important whenever themysql
package is occurring multiple times in the dependency tree of a consumer package./* eslint-disable no-use-before-define */
because the new implementation explicitly makes use of the variable hoisting to make the callback wrappers work.node-mysql-utilities
.Checks:
npm t
)npm run fmt
)