Conversation
seveibar
deleted the
revert-43-codex/fix-startdevserver2-to-not-persistently-run-esbuild
branch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
|
||
| const handleFileChange = async (isManifestChange: boolean = false) => { | ||
| if (isManifestChange) { | ||
| manifestNeedsUpdate = true | ||
| await updateManifest() | ||
| } | ||
| await build() | ||
| } |
There was a problem hiding this comment.
[P1] Serialize concurrent rebuilds
The revert drops the isBuilding/rebuildScheduled gating, so every watcher event now calls build() without any concurrency control. Because the file watchers invoke their async handlers without awaiting them, two quick file changes will run build() in parallel. Esbuild’s BuildContext.rebuild() must not be invoked while a previous rebuild is still running, so concurrent calls will throw and the dev server will report repeated build failures instead of queuing the change. Please reintroduce a mutex/queue so only one rebuild runs at a time.
Useful? React with 👍 / 👎.
1 participant
Reverts #43