feat: add is_extended_promotional field to all component tables#141
Open
soongtv wants to merge 3 commits intotscircuit:mainfrom
Open
feat: add is_extended_promotional field to all component tables#141soongtv wants to merge 3 commits intotscircuit:mainfrom
soongtv wants to merge 3 commits intotscircuit:mainfrom
Conversation
- Add is_extended_promotional boolean field to BaseComponent interface - Update all 37 component table definitions to include the new field - Map extended_promotional from source data - Add bulk update script for future field additions Closes tscircuit#92
|
Closing this PR in favor of #145 which uses a lighter computed field approach instead of database schema changes. The new implementation doesn't require modifying 37 component tables and is easier to maintain. Thanks for reviewing! |
🔄 Superseded by #145Closing this PR in favor of #145 which uses a lighter computed field approach. Why the new approach is better:
Implementation difference:PR #141: Adds real database column is_extended_promotional to all 37 component tables The computed field approach is cleaner since is_extended_promotional is derived data, not source data. Thanks for the review! /claim #92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the feature requested in issue #92 to add an \is_extended_promotional\ column to all component tables.
Changes
1. Core Interface Update
2. Component Table Updates
Updated all 37 component table definitions to include the new field:
3. Data Mapping
4. Utility Script
Testing
Note: Full database testing requires the complete 2GB database setup, which should be performed by maintainers with proper infrastructure.
The implementation follows the same pattern as existing fields (\is_basic, \is_preferred) and is compatible with the existing data pipeline.
Related Issue
Closes #92
PayPal for bounty: [email protected]