feat: add is_extended_promotional column to all component tables#135
Open
ckmtools wants to merge 1 commit intotscircuit:mainfrom
Open
feat: add is_extended_promotional column to all component tables#135ckmtools wants to merge 1 commit intotscircuit:mainfrom
ckmtools wants to merge 1 commit intotscircuit:mainfrom
Conversation
- Added `extended_promotional` field to Component interface in kysely types - Added `is_extended_promotional` to BaseComponent and DerivedTableSpec type - Updated all 37 derived table specs with column definition and mapping - Created database index optimization for extended_promotional queries - Added filtering support in components list UI (checkbox) and API search - Exposed `is_extended_promotional` in API response payloads /claim tscircuit#92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extended_promotionalfield to the Component database interfaceBaseComponentandDerivedTableSpectypes to includeis_extended_promotionalis_extended_promotionalcolumn definition and mapping to all 37 derived component tablesidx_components_extended_promotionaldatabase index optimization for faster queriescomponents/listroute with filterable checkbox and API response fieldapi/searchendpoint withis_extended_promotionalquery parameter supportVComponentview interface withextended_promotionalfieldContext
Extended promotional parts are components that act as basic parts for a limited time period. This PR exposes that information as a filterable column, following the same pattern as the existing
is_basicandis_preferredcolumns.Changes
lib/db/generated/kysely.ts): Addedextended_promotionaltoComponentandVComponent, addedis_extended_promotionalto all 37 derived table interfaceslib/db/derivedtables/component-base.ts,types.ts): Addedis_extended_promotional: booleanBoolean(c.extended_promotional)mappinglib/db/optimizations/component-extended-promotional-index.ts): New index for query performanceroutes/components/list.tsx,routes/api/search.tsx): Added filtering and response mappingFixes #92
/claim #92