Add is_extended_promotional filter to components list and API search#129
Open
gavin-openops wants to merge 1 commit intotscircuit:mainfrom
Open
Add is_extended_promotional filter to components list and API search#129gavin-openops wants to merge 1 commit intotscircuit:mainfrom
gavin-openops wants to merge 1 commit intotscircuit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #92
Summary
is_extended_promotionalas an optional query param on:/components/list(.json)/api/searchjson_extract(extra, "$.is_extended_promotional") = 1is_extended_promotionalto response payloads by parsing each component'sextraJSONroutes/components/list.tsxby selectingpreferredsois_preferredin output works correctlyWhy
Issue #92 asks for extended promotional status to be available in a filterable column. This change exposes and filters that status without requiring a schema migration, since the flag is already available from component
extraJSON.Validation
bun run format✅bun run format:check✅bun testIf maintainers prefer this flag materialized as a dedicated DB column in derived tables, I can follow up with that migration path too.